Change default ink drop center points to center of contents bounds

Change default ink drop center points to center of contents bounds
rather than local bounds.

This needs RTL mirroring, so introduce utility View::GetMirroredRect()
and use it to reduce verbosity in a bunch of places that are currently
using GetMirroredXForRect().

BUG=724675
Review-Url: https://codereview.chromium.org/2897533003
Cr-Commit-Position: refs/heads/master@{#474120}
Committed: https://chromium.googlesource.com/chromium/src/+/8c7cdc7b3156ce8527708922c7b6b1208ad805f0

[Evan Stade, 2017-05-19 16:21:02]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 16:21:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 18:01:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 18:02:00]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2017-05-19 22:40:35]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 22:41:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 23:41:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 23:41:09]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2017-05-22 20:26:17]

Description was changed from

==========
Change default ink drop center points to center of contents bounds
rather than local bounds.

BUG=none
==========

to

==========
Change default ink drop center points to center of contents bounds
rather than local bounds.

This needs RTL mirroring, so introduce utility View::GetMirroredRect()
and use it to reduce verbosity in a bunch of places that are currently
using GetMirroredXForRect().

BUG=724675
==========

[Evan Stade, 2017-05-22 20:26:18]

estade@chromium.org changed reviewers:
+ bruthig@chromium.org, sky@chromium.org

[Evan Stade, 2017-05-22 20:26:55]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 20:27:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 20:45:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 20:45:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bruthig, 2017-05-23 14:43:31]

ink_drop* looks good to me with nit

https://codereview.chromium.org/2897533003/diff/60001/ui/views/animation/ink_...
File ui/views/animation/ink_drop_host_view.h (right):

https://codereview.chromium.org/2897533003/diff/60001/ui/views/animation/ink_...
ui/views/animation/ink_drop_host_view.h:137: gfx::PointF
GetMirroredCenterPoint() const;
nit: This doesn't appear to be used?

[Evan Stade, 2017-05-23 15:22:43]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 15:23:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 15:40:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 15:40:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2017-05-23 18:02:18]

Nice simplification! LGTM

[Evan Stade, 2017-05-23 23:02:38]

https://codereview.chromium.org/2897533003/diff/60001/ui/views/animation/ink_...
File ui/views/animation/ink_drop_host_view.h (right):

https://codereview.chromium.org/2897533003/diff/60001/ui/views/animation/ink_...
ui/views/animation/ink_drop_host_view.h:137: gfx::PointF
GetMirroredCenterPoint() const;
On 2017/05/23 14:43:31, bruthig wrote:
> nit: This doesn't appear to be used?

Done.

[Evan Stade, 2017-05-23 23:03:09]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-05-23 23:03:09]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2897533003/#ps100001
(title: "fix compile")

[commit-bot: I haz the power, 2017-05-23 23:04:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 00:25:34]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495580589195410,
"parent_rev": "1ffa477756f92b6a6a318a0d6689e04f398c5705", "commit_rev":
"8c7cdc7b3156ce8527708922c7b6b1208ad805f0"}

[commit-bot: I haz the power, 2017-05-24 00:25:45]

Description was changed from

==========
Change default ink drop center points to center of contents bounds
rather than local bounds.

This needs RTL mirroring, so introduce utility View::GetMirroredRect()
and use it to reduce verbosity in a bunch of places that are currently
using GetMirroredXForRect().

BUG=724675
==========

to

==========
Change default ink drop center points to center of contents bounds
rather than local bounds.

This needs RTL mirroring, so introduce utility View::GetMirroredRect()
and use it to reduce verbosity in a bunch of places that are currently
using GetMirroredXForRect().

BUG=724675

Review-Url: https://codereview.chromium.org/2897533003
Cr-Commit-Position: refs/heads/master@{#474120}
Committed:
https://chromium.googlesource.com/chromium/src/+/8c7cdc7b3156ce8527708922c7b6...
==========

[commit-bot: I haz the power, 2017-05-24 00:25:47]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/8c7cdc7b3156ce8527708922c7b6...