Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2897483003: Attempt #3 at registry outage: ShellExecute reg delete (Closed)

Created:
3 years, 7 months ago by gab
Modified:
3 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Attempt #3 at registry outage: ShellExecute reg delete Nuclear option to be reverted after the bots heal up. BUG=721245 R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2897483003 . Cr-Commit-Position: refs/heads/master@{#472945} Committed: https://chromium.googlesource.com/chromium/src/+/f26f6233d2d8be69c638ddac047db13fd6f14062

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -20 lines) Patch
M chrome/test/base/chrome_test_launcher.cc View 3 chunks +33 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
gab
Nico PTaL, this is urgent to attempt the fix the registry on Win bots.
3 years, 7 months ago (2017-05-18 22:00:12 UTC) #4
Nico
Rs-lgtm, good luck!
3 years, 7 months ago (2017-05-18 22:01:46 UTC) #5
gab
Committed patchset #1 (id:1) manually as f26f6233d2d8be69c638ddac047db13fd6f14062 (presubmit successful).
3 years, 7 months ago (2017-05-18 22:03:59 UTC) #7
gab
3 years, 7 months ago (2017-05-23 14:20:53 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2902683003/ by gab@chromium.org.

The reason for reverting is: Nuclear cleanup no longer needed (and having
reg.exe run in parallel with the browser_tests that are starting can cause
flakiness in itself)..

Powered by Google App Engine
This is Rietveld 408576698