Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2897483002: PPC/s390: Reland: [Interpreter] Transition JSFunctions to call optimized code when possible. (Closed)

Created:
3 years, 7 months ago by JaideepBajwa
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: Reland: [Interpreter] Transition JSFunctions to call optimized code when possible. Port 73d21080c96dc41caf7abcff6d22578520e50fd3 Original Commit Message: Now that the optimized code hangs off the feedback vector, it is possible to check whether a function has optimized code available every time it's called in the interpreter entry trampoline. If optimized code exists, the interpreter entry trampoline 'self-heals' the closure to point to the optimized code and links the closure into the optimized code list. R=rmcilroy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:6246 LOG=N Review-Url: https://codereview.chromium.org/2897483002 Cr-Commit-Position: refs/heads/master@{#45410} Committed: https://chromium.googlesource.com/v8/v8/+/fc738f1e3264820a84ae0bc4ca9c045ca1469c8a

Patch Set 1 #

Patch Set 2 : s390 port #

Patch Set 3 : minor fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -50 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 1 2 4 chunks +74 lines, -25 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 2 4 chunks +74 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 7 months ago (2017-05-18 23:07:54 UTC) #1
john.yan
lgtm
3 years, 7 months ago (2017-05-18 23:08:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897483002/40001
3 years, 7 months ago (2017-05-18 23:09:11 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 23:38:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/fc738f1e3264820a84ae0bc4ca9c045ca14...

Powered by Google App Engine
This is Rietveld 408576698