Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 2897403003: web_dev_style: actually restore sys.path in various PRESUBMITs (Closed)

Created:
3 years, 7 months ago by Dan Beam
Modified:
3 years, 7 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

web_dev_style: actually restore sys.path in various PRESUBMITs R=dpapad@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2897403003 Cr-Commit-Position: refs/heads/master@{#474488} Committed: https://chromium.googlesource.com/chromium/src/+/574fe09c0a5017c087b7b856404d021830f88e53

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/resources/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M components/about_ui/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M components/flags_ui/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M components/version_ui/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Dan Beam
3 years, 7 months ago (2017-05-24 22:53:54 UTC) #2
dpapad
lgtm
3 years, 7 months ago (2017-05-24 22:55:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897403003/1
3 years, 7 months ago (2017-05-25 00:14:35 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 00:21:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/574fe09c0a5017c087b7b856404d...

Powered by Google App Engine
This is Rietveld 408576698