VR feedback reports should go directly to the Feedback activity

VR feedback reports should go directly to the Feedback activity

This CL has the following changes
- Adds a showFeedback method to HelpAndFeedback which starts Feedback
  without the "Help" portion.
- FeedbackCollector can be initialized to not take screenshots (screenshot
  makes less sense for the VR feedback usecase).
- FeedbackCollector can set a CategoryTag to route the reports to a specific bucket.

BUG=722972
Review-Url: https://codereview.chromium.org/2897323002
Cr-Commit-Position: refs/heads/master@{#474915}
Committed: https://chromium.googlesource.com/chromium/src/+/c99b85c688dad6fa669e73f147b6d74165c7ffd4

[ymalik, 2017-05-24 16:51:57]

Description was changed from

==========
VR feedback reports should go directly to the Feedback activity

This CL has the following changes
- Adds a showFeedback method to HelpAndFeedback which starts Feedback without
    help.
- FeedbackCollector can be initialized to not take screenshots (screenshot
    makes less sense for the VR feedback usecase).

BUG=722972
==========

to

==========
VR feedback reports should go directly to the Feedback activity

This CL has the following changes
- Adds a showFeedback method to HelpAndFeedback which starts Feedback without
    help.
- FeedbackCollector can be initialized to not take screenshots (screenshot
    makes less sense for the VR feedback usecase).
- FeedbackColelctor can set a CategoryTag to route the reports to a specific
    bucket.

BUG=722972
==========

[ymalik, 2017-05-24 16:53:04]

Description was changed from

==========
VR feedback reports should go directly to the Feedback activity

This CL has the following changes
- Adds a showFeedback method to HelpAndFeedback which starts Feedback without
    help.
- FeedbackCollector can be initialized to not take screenshots (screenshot
    makes less sense for the VR feedback usecase).
- FeedbackColelctor can set a CategoryTag to route the reports to a specific
    bucket.

BUG=722972
==========

to

==========
VR feedback reports should go directly to the Feedback activity

This CL has the following changes
- Adds a showFeedback method to HelpAndFeedback which starts Feedback
  without the "Help" portion.
- FeedbackCollector can be initialized to not take screenshots (screenshot
  makes less sense for the VR feedback usecase).
- FeedbackColelctor can set a CategoryTag to route the reports to a specific
bucket.

BUG=722972
==========

[ymalik, 2017-05-24 16:55:10]

The CQ bit was checked by ymalik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 16:55:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 16:58:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 16:58:53]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ymalik, 2017-05-24 17:14:25]

The CQ bit was checked by ymalik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 17:15:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ymalik, 2017-05-24 17:17:05]

ymalik@chromium.org changed reviewers:
+ mthiesse@chromium.org, nyquist@chromium.org

[commit-bot: I haz the power, 2017-05-24 18:23:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 18:23:27]

Dry run: This issue passed the CQ dry run.

[mthiesse, 2017-05-24 22:37:58]

Description was changed from

==========
VR feedback reports should go directly to the Feedback activity

This CL has the following changes
- Adds a showFeedback method to HelpAndFeedback which starts Feedback
  without the "Help" portion.
- FeedbackCollector can be initialized to not take screenshots (screenshot
  makes less sense for the VR feedback usecase).
- FeedbackColelctor can set a CategoryTag to route the reports to a specific
bucket.

BUG=722972
==========

to

==========
VR feedback reports should go directly to the Feedback activity

This CL has the following changes
- Adds a showFeedback method to HelpAndFeedback which starts Feedback
  without the "Help" portion.
- FeedbackCollector can be initialized to not take screenshots (screenshot
  makes less sense for the VR feedback usecase).
- FeedbackCollector can set a CategoryTag to route the reports to a specific
bucket.

BUG=722972
==========

[mthiesse, 2017-05-24 22:41:14]

vr_shell/ lgtm

[ymalik, 2017-05-25 21:13:46]

gentle ping

[nyquist, 2017-05-25 21:56:24]

lgtm % nits

https://codereview.chromium.org/2897323002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java
(right):

https://codereview.chromium.org/2897323002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java:76:
private boolean mTakeScreenshot;
Nit: Make this final and put it with the rest of the final data. Down here it
looks like it's going to be filled in as state over time.

https://codereview.chromium.org/2897323002/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/feedback/FeedbackCollectorTest.java
(right):

https://codereview.chromium.org/2897323002/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/feedback/FeedbackCollectorTest.java:378:
"Failed to acquire semaphore.", semaphore.tryAcquire(1, TimeUnit.SECONDS));
Nit: I'd use 5 seconds for UI-timeouts like this. There are many devices out
there that are horribly slow. It's not supposed to happen normally, so it's fine
to have a higher value than you would typically use.

[ymalik, 2017-05-25 23:44:25]

https://codereview.chromium.org/2897323002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java
(right):

https://codereview.chromium.org/2897323002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java:76:
private boolean mTakeScreenshot;
On 2017/05/25 21:56:24, nyquist (nychthemeron ping) wrote:
> Nit: Make this final and put it with the rest of the final data. Down here it
> looks like it's going to be filled in as state over time.

Done.

https://codereview.chromium.org/2897323002/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/feedback/FeedbackCollectorTest.java
(right):

https://codereview.chromium.org/2897323002/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/feedback/FeedbackCollectorTest.java:378:
"Failed to acquire semaphore.", semaphore.tryAcquire(1, TimeUnit.SECONDS));
On 2017/05/25 21:56:24, nyquist (nychthemeron ping) wrote:
> Nit: I'd use 5 seconds for UI-timeouts like this. There are many devices out
> there that are horribly slow. It's not supposed to happen normally, so it's
fine
> to have a higher value than you would typically use.

Done.

[ymalik, 2017-05-25 23:44:28]

The CQ bit was checked by ymalik@chromium.org

[ymalik, 2017-05-25 23:44:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
nyquist@chromium.org, mthiesse@chromium.org
Link to the patchset: https://codereview.chromium.org/2897323002/#ps40001
(title: "apply nits")

[commit-bot: I haz the power, 2017-05-25 23:45:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 05:09:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495755868917750,
"parent_rev": "f04ef6cf643d773e4176cbc4142251b18e959b7f", "commit_rev":
"c99b85c688dad6fa669e73f147b6d74165c7ffd4"}

[commit-bot: I haz the power, 2017-05-26 05:09:43]

Description was changed from

==========
VR feedback reports should go directly to the Feedback activity

This CL has the following changes
- Adds a showFeedback method to HelpAndFeedback which starts Feedback
  without the "Help" portion.
- FeedbackCollector can be initialized to not take screenshots (screenshot
  makes less sense for the VR feedback usecase).
- FeedbackCollector can set a CategoryTag to route the reports to a specific
bucket.

BUG=722972
==========

to

==========
VR feedback reports should go directly to the Feedback activity

This CL has the following changes
- Adds a showFeedback method to HelpAndFeedback which starts Feedback
  without the "Help" portion.
- FeedbackCollector can be initialized to not take screenshots (screenshot
  makes less sense for the VR feedback usecase).
- FeedbackCollector can set a CategoryTag to route the reports to a specific
bucket.

BUG=722972

Review-Url: https://codereview.chromium.org/2897323002
Cr-Commit-Position: refs/heads/master@{#474915}
Committed:
https://chromium.googlesource.com/chromium/src/+/c99b85c688dad6fa669e73f147b6...
==========

[commit-bot: I haz the power, 2017-05-26 05:09:44]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c99b85c688dad6fa669e73f147b6...