Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2897313003: Remove duplicate service wrkr "uncontrolled" test (Closed)

Created:
3 years, 7 months ago by mike3
Modified:
3 years, 7 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove duplicate service wrkr "uncontrolled" test This test is identical to the version available in the Web Platform Tests project and may therefore be removed without impacting coverage. BUG=688116 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2897313003 Cr-Commit-Position: refs/heads/master@{#474902} Committed: https://chromium.googlesource.com/chromium/src/+/8712f4d7c992f65300438340d211945c75a7f87d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -44 lines) Patch
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fail-on-fetch-worker.js View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/uncontrolled-page.html View 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mike3
Here's an easy one, Matt :) Diff: https://gist.github.com/jugglinmike/d3e665a09c325b5617d96d1c4e37dd67
3 years, 7 months ago (2017-05-24 21:27:24 UTC) #1
falken
lgtm
3 years, 7 months ago (2017-05-26 01:23:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897313003/1
3 years, 7 months ago (2017-05-26 01:24:12 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 03:59:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8712f4d7c992f65300438340d211...

Powered by Google App Engine
This is Rietveld 408576698