Android: Simplify isTablet and InterfaceRegistrars

Android: Simplify isTablet and InterfaceRegistrars

Clean-up after downstream changes landed to reduce passing around the
same global application context. Saves ~220 bytes.

BUG=646094
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2897313002
Cr-Commit-Position: refs/heads/master@{#474697}
Committed: https://chromium.googlesource.com/chromium/src/+/7848fec2384849ec0663c96d3bc73e9e3afd6e25

[Peter Wen, 2017-05-24 16:35:34]

Description was changed from

==========
Android: Simplify isTablet and InterfaceRegistrars

Clean-up after downstream changes landed to reduce passing around the
same global application context. Saves ~220 bytes.

BUG=646094
==========

to

==========
Android: Simplify isTablet and InterfaceRegistrars

Clean-up after downstream changes landed to reduce passing around the
same global application context. Saves ~220 bytes.

BUG=646094
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Peter Wen, 2017-05-24 16:35:44]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 16:36:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2017-05-24 18:09:46]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 18:10:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2017-05-24 18:11:13]

wnwen@chromium.org changed reviewers:
+ estevenson@chromium.org

[Peter Wen, 2017-05-24 18:11:13]

Hi Eric,

Mind taking a look at this follow-up fix for GetApplicationContext?

Thanks,

Peter

[commit-bot: I haz the power, 2017-05-24 19:53:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 19:53:48]

Dry run: This issue passed the CQ dry run.

[estevenson, 2017-05-24 21:34:45]

On 2017/05/24 18:11:13, Peter Wen wrote:
> Hi Eric,
> 
> Mind taking a look at this follow-up fix for GetApplicationContext?
> 
> Thanks,
> 
> Peter

lgtm!

[Peter Wen, 2017-05-25 12:02:10]

wnwen@chromium.org changed reviewers:
+ reillyg@chromium.org, tedchoc@chromium.org

[Peter Wen, 2017-05-25 12:02:11]

Thanks for your review, Eric!

+tedchoc@ for content/android and ui/android OWNERS.
+reillyg@ for services/shape_detection and services/device OWNERS.

[Ted C, 2017-05-25 14:03:09]

lgtm

[Reilly Grant (use Gerrit), 2017-05-25 14:27:26]

lgtm with a nit

https://codereview.chromium.org/2897313002/diff/20001/services/device/vibrati...
File
services/device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java
(right):

https://codereview.chromium.org/2897313002/diff/20001/services/device/vibrati...
services/device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java:39:
mAudioManager = (AudioManager)
ContextUtils.getApplicationContext().getSystemService(
This would be more readable if you saved ContextUtils.getApplicationContext() in
a local variable at the top of the function.

[Peter Wen, 2017-05-25 15:24:06]

Thanks for the quick reviews!

https://codereview.chromium.org/2897313002/diff/20001/services/device/vibrati...
File
services/device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java
(right):

https://codereview.chromium.org/2897313002/diff/20001/services/device/vibrati...
services/device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java:39:
mAudioManager = (AudioManager)
ContextUtils.getApplicationContext().getSystemService(
On 2017/05/25 14:27:25, Reilly Grant wrote:
> This would be more readable if you saved ContextUtils.getApplicationContext()
in
> a local variable at the top of the function.

Done, thanks!

[Peter Wen, 2017-05-25 15:24:11]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2017-05-25 15:24:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, estevenson@chromium.org, reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/2897313002/#ps40001
(title: "Pull out local variable")

[commit-bot: I haz the power, 2017-05-25 15:24:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 17:37:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 17:37:55]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peter Wen, 2017-05-25 17:45:00]

The CQ bit was checked by wnwen@chromium.org

[commit-bot: I haz the power, 2017-05-25 17:45:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 17:55:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495734300924610,
"parent_rev": "1f6d93dd40c218bea0718132b326146ce177c16d", "commit_rev":
"7848fec2384849ec0663c96d3bc73e9e3afd6e25"}

[commit-bot: I haz the power, 2017-05-25 17:56:11]

Description was changed from

==========
Android: Simplify isTablet and InterfaceRegistrars

Clean-up after downstream changes landed to reduce passing around the
same global application context. Saves ~220 bytes.

BUG=646094
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Android: Simplify isTablet and InterfaceRegistrars

Clean-up after downstream changes landed to reduce passing around the
same global application context. Saves ~220 bytes.

BUG=646094
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2897313002
Cr-Commit-Position: refs/heads/master@{#474697}
Committed:
https://chromium.googlesource.com/chromium/src/+/7848fec2384849ec0663c96d3bc7...
==========

[commit-bot: I haz the power, 2017-05-25 17:56:12]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7848fec2384849ec0663c96d3bc7...