Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2897303002: chromeos: Changes DisplayManagerObserver to have a single function (Closed)

Created:
3 years, 7 months ago by sky
Modified:
3 years, 7 months ago
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Changes DisplayManagerObserver to have a single function Having a single function handle all updates makes it easy for simplified display management where the window-manager needs to call a single function that updates everything. BUG=706589 TEST=covered by tests R=erg@chromium.org, tsepez@chromium.org Review-Url: https://codereview.chromium.org/2897303002 Cr-Commit-Position: refs/heads/master@{#474426} Committed: https://chromium.googlesource.com/chromium/src/+/5dee298442f93c6a40c41bd74fd50260cd2dfba1

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -162 lines) Patch
M services/ui/public/interfaces/display_manager.mojom View 1 1 chunk +9 lines, -20 lines 0 comments Download
M services/ui/ws/display.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/display_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/display_manager.cc View 1 2 3 chunks +11 lines, -8 lines 0 comments Download
M services/ui/ws/user_display_manager.h View 1 2 chunks +10 lines, -5 lines 0 comments Download
M services/ui/ws/user_display_manager.cc View 1 5 chunks +28 lines, -54 lines 0 comments Download
M services/ui/ws/user_display_manager_unittest.cc View 5 chunks +8 lines, -17 lines 0 comments Download
M ui/views/mus/screen_mus.h View 2 chunks +5 lines, -7 lines 0 comments Download
M ui/views/mus/screen_mus.cc View 2 chunks +51 lines, -49 lines 0 comments Download
M ui/views/mus/screen_mus_unittest.cc View 2 chunks +74 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (16 generated)
sky
tsepez: mojom erg: the rest
3 years, 7 months ago (2017-05-24 16:14:30 UTC) #1
Elliot Glaysher
lgtm
3 years, 7 months ago (2017-05-24 17:05:54 UTC) #6
sky
+the-real-tsepez (and not a misspelling)
3 years, 7 months ago (2017-05-24 17:57:27 UTC) #10
Tom Sepez
lgtm
3 years, 7 months ago (2017-05-24 19:15:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897303002/40001
3 years, 7 months ago (2017-05-24 20:04:51 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/446596)
3 years, 7 months ago (2017-05-24 20:13:32 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897303002/40001
3 years, 7 months ago (2017-05-24 21:10:25 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 21:16:33 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5dee298442f93c6a40c41bd74fd5...

Powered by Google App Engine
This is Rietveld 408576698