Issue 2897263002: Add KernelToElementMap.getSpannable to avoid most usage of KernelAstAdapter.getNode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2897263002: Add KernelToElementMap.getSpannable to avoid most usage of KernelAstAdapter.getNode (Closed)

Created:
3 years, 7 months ago by Johnni Winther

Modified:
3 years, 6 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Add KernelToElementMap.getSpannable to avoid most usage of KernelAstAdapter.getNode R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/133149d78b7a29b58a86d53b2b3453fe83f5e2cf

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -24 lines)			Patch
M	pkg/compiler/lib/src/kernel/element_map.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/kernel/element_map_impl.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder_kernel.dart	View	20 chunks	+37 lines, -23 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/ssa_branch_builder.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Johnni Winther

3 years, 6 months ago (2017-05-29 08:10:02 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
133149d78b7a29b58a86d53b2b3453fe83f5e2cf (presubmit successful).