Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart

Issue 2897263002: Add KernelToElementMap.getSpannable to avoid most usage of KernelAstAdapter.getNode (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'package:js_runtime/shared/embedded_names.dart'; 5 import 'package:js_runtime/shared/embedded_names.dart';
6 import 'package:kernel/ast.dart' as ir; 6 import 'package:kernel/ast.dart' as ir;
7 7
8 import '../closure.dart'; 8 import '../closure.dart';
9 import '../common.dart'; 9 import '../common.dart';
10 import '../compiler.dart'; 10 import '../compiler.dart';
(...skipping 391 matching lines...) Expand 10 before | Expand all | Expand 10 after
402 getClass(cls), getDartTypes(typeArguments)); 402 getClass(cls), getDartTypes(typeArguments));
403 } 403 }
404 404
405 MemberEntity getConstructorBodyEntity(ir.Constructor constructor) { 405 MemberEntity getConstructorBodyEntity(ir.Constructor constructor) {
406 AstElement element = getElement(constructor); 406 AstElement element = getElement(constructor);
407 MemberEntity constructorBody = 407 MemberEntity constructorBody =
408 ConstructorBodyElementX.createFromResolvedAst(element.resolvedAst); 408 ConstructorBodyElementX.createFromResolvedAst(element.resolvedAst);
409 assert(constructorBody != null); 409 assert(constructorBody != null);
410 return constructorBody; 410 return constructorBody;
411 } 411 }
412
413 @override
414 Spannable getSpannable(MemberEntity member, ir.Node node) {
415 return getNode(node);
416 }
412 } 417 }
413 418
414 /// Visitor that converts kernel dart types into [ResolutionDartType]. 419 /// Visitor that converts kernel dart types into [ResolutionDartType].
415 class DartTypeConverter extends ir.DartTypeVisitor<ResolutionDartType> { 420 class DartTypeConverter extends ir.DartTypeVisitor<ResolutionDartType> {
416 final KernelAstAdapter astAdapter; 421 final KernelAstAdapter astAdapter;
417 bool topLevel = true; 422 bool topLevel = true;
418 423
419 DartTypeConverter(this.astAdapter); 424 DartTypeConverter(this.astAdapter);
420 425
421 ResolutionDartType convert(ir.DartType type) { 426 ResolutionDartType convert(ir.DartType type) {
(...skipping 282 matching lines...) Expand 10 before | Expand all | Expand 10 after
704 TypeMask selectorTypeOf(Selector selector, TypeMask mask) { 709 TypeMask selectorTypeOf(Selector selector, TypeMask mask) {
705 return TypeMaskFactory.inferredTypeForSelector( 710 return TypeMaskFactory.inferredTypeForSelector(
706 selector, mask, _globalInferenceResults); 711 selector, mask, _globalInferenceResults);
707 } 712 }
708 713
709 TypeMask typeFromNativeBehavior( 714 TypeMask typeFromNativeBehavior(
710 native.NativeBehavior nativeBehavior, ClosedWorld closedWorld) { 715 native.NativeBehavior nativeBehavior, ClosedWorld closedWorld) {
711 return TypeMaskFactory.fromNativeBehavior(nativeBehavior, closedWorld); 716 return TypeMaskFactory.fromNativeBehavior(nativeBehavior, closedWorld);
712 } 717 }
713 } 718 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/ssa/builder_kernel.dart ('k') | pkg/compiler/lib/src/ssa/ssa_branch_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698