OLD | NEW |
1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h" | 5 #include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h" |
6 | 6 |
7 #include "base/time/time.h" | 7 #include "base/time/time.h" |
8 #include "base/timer/mock_timer.h" | 8 #include "base/timer/mock_timer.h" |
9 #include "chrome/common/page_load_metrics/page_load_metrics.mojom.h" | 9 #include "chrome/common/page_load_metrics/page_load_timing.h" |
10 #include "chrome/renderer/page_load_metrics/fake_page_timing_sender.h" | 10 #include "chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.
h" |
| 11 #include "ipc/ipc_message.h" |
11 #include "testing/gtest/include/gtest/gtest.h" | 12 #include "testing/gtest/include/gtest/gtest.h" |
12 | 13 |
13 namespace page_load_metrics { | 14 namespace page_load_metrics { |
14 | 15 |
15 // Thin wrapper around PageTimingMetricsSender that provides access to the | 16 // Thin wrapper around PageTimingMetricsSender that provides access to the |
16 // MockTimer instance. | 17 // MockTimer instance. |
17 class TestPageTimingMetricsSender : public PageTimingMetricsSender { | 18 class TestPageTimingMetricsSender : public PageTimingMetricsSender { |
18 public: | 19 public: |
19 explicit TestPageTimingMetricsSender( | 20 explicit TestPageTimingMetricsSender(IPC::Sender* ipc_sender, |
20 std::unique_ptr<PageTimingSender> page_timing_sender, | 21 mojom::PageLoadTimingPtr initial_timing) |
21 mojom::PageLoadTimingPtr initial_timing) | |
22 : PageTimingMetricsSender( | 22 : PageTimingMetricsSender( |
23 std::move(page_timing_sender), | 23 ipc_sender, |
| 24 MSG_ROUTING_NONE, |
24 std::unique_ptr<base::Timer>(new base::MockTimer(false, false)), | 25 std::unique_ptr<base::Timer>(new base::MockTimer(false, false)), |
25 std::move(initial_timing)) {} | 26 std::move(initial_timing)) {} |
26 | 27 |
27 base::MockTimer* mock_timer() const { | 28 base::MockTimer* mock_timer() const { |
28 return reinterpret_cast<base::MockTimer*>(timer()); | 29 return reinterpret_cast<base::MockTimer*>(timer()); |
29 } | 30 } |
30 }; | 31 }; |
31 | 32 |
32 class PageTimingMetricsSenderTest : public testing::Test { | 33 class PageTimingMetricsSenderTest : public testing::Test { |
33 public: | 34 public: |
34 PageTimingMetricsSenderTest() | 35 PageTimingMetricsSenderTest() |
35 : metrics_sender_(new TestPageTimingMetricsSender( | 36 : metrics_sender_( |
36 base::MakeUnique<FakePageTimingSender>(&validator_), | 37 new TestPageTimingMetricsSender(&fake_ipc_sender_, |
37 mojom::PageLoadTiming::New())) {} | 38 mojom::PageLoadTiming::New())) {} |
38 | 39 |
39 protected: | 40 protected: |
40 FakePageTimingSender::PageTimingValidator validator_; | 41 FakePageTimingMetricsIPCSender fake_ipc_sender_; |
41 std::unique_ptr<TestPageTimingMetricsSender> metrics_sender_; | 42 std::unique_ptr<TestPageTimingMetricsSender> metrics_sender_; |
42 }; | 43 }; |
43 | 44 |
44 TEST_F(PageTimingMetricsSenderTest, Basic) { | 45 TEST_F(PageTimingMetricsSenderTest, Basic) { |
45 base::Time nav_start = base::Time::FromDoubleT(10); | 46 base::Time nav_start = base::Time::FromDoubleT(10); |
46 base::TimeDelta first_layout = base::TimeDelta::FromMillisecondsD(2); | 47 base::TimeDelta first_layout = base::TimeDelta::FromMillisecondsD(2); |
47 | 48 |
48 mojom::PageLoadTiming timing; | 49 mojom::PageLoadTiming timing; |
49 InitPageLoadTimingForTest(&timing); | 50 page_load_metrics::InitPageLoadTimingForTest(&timing); |
50 timing.navigation_start = nav_start; | 51 timing.navigation_start = nav_start; |
51 timing.document_timing->first_layout = first_layout; | 52 timing.document_timing->first_layout = first_layout; |
52 | 53 |
53 metrics_sender_->Send(timing.Clone()); | 54 metrics_sender_->Send(timing.Clone()); |
54 | 55 |
55 // Firing the timer should trigger sending of an SendTiming call. | 56 // Firing the timer should trigger sending of an OnTimingUpdated IPC. |
56 validator_.ExpectPageLoadTiming(timing); | 57 fake_ipc_sender_.ExpectPageLoadTiming(timing); |
57 ASSERT_TRUE(metrics_sender_->mock_timer()->IsRunning()); | 58 ASSERT_TRUE(metrics_sender_->mock_timer()->IsRunning()); |
58 metrics_sender_->mock_timer()->Fire(); | 59 metrics_sender_->mock_timer()->Fire(); |
59 EXPECT_FALSE(metrics_sender_->mock_timer()->IsRunning()); | 60 EXPECT_FALSE(metrics_sender_->mock_timer()->IsRunning()); |
60 | 61 |
61 // At this point, we should have triggered the send of the SendTiming call. | 62 // At this point, we should have triggered the send of the PageLoadTiming IPC. |
62 validator_.VerifyExpectedTimings(); | 63 fake_ipc_sender_.VerifyExpectedTimings(); |
63 | 64 |
64 // Attempt to send the same timing instance again. The send should be | 65 // Attempt to send the same timing instance again. The send should be |
65 // suppressed, since the timing instance hasn't changed since the last send. | 66 // suppressed, since the timing instance hasn't changed since the last send. |
66 metrics_sender_->Send(timing.Clone()); | 67 metrics_sender_->Send(timing.Clone()); |
67 EXPECT_FALSE(metrics_sender_->mock_timer()->IsRunning()); | 68 EXPECT_FALSE(metrics_sender_->mock_timer()->IsRunning()); |
68 } | 69 } |
69 | 70 |
70 TEST_F(PageTimingMetricsSenderTest, CoalesceMultipleTimings) { | 71 TEST_F(PageTimingMetricsSenderTest, CoalesceMultipleIPCs) { |
71 base::Time nav_start = base::Time::FromDoubleT(10); | 72 base::Time nav_start = base::Time::FromDoubleT(10); |
72 base::TimeDelta first_layout = base::TimeDelta::FromMillisecondsD(2); | 73 base::TimeDelta first_layout = base::TimeDelta::FromMillisecondsD(2); |
73 base::TimeDelta load_event = base::TimeDelta::FromMillisecondsD(4); | 74 base::TimeDelta load_event = base::TimeDelta::FromMillisecondsD(4); |
74 | 75 |
75 mojom::PageLoadTiming timing; | 76 mojom::PageLoadTiming timing; |
76 InitPageLoadTimingForTest(&timing); | 77 page_load_metrics::InitPageLoadTimingForTest(&timing); |
77 timing.navigation_start = nav_start; | 78 timing.navigation_start = nav_start; |
78 timing.document_timing->first_layout = first_layout; | 79 timing.document_timing->first_layout = first_layout; |
79 | 80 |
80 metrics_sender_->Send(timing.Clone()); | 81 metrics_sender_->Send(timing.Clone()); |
81 ASSERT_TRUE(metrics_sender_->mock_timer()->IsRunning()); | 82 ASSERT_TRUE(metrics_sender_->mock_timer()->IsRunning()); |
82 | 83 |
83 // Send an updated PageLoadTiming before the timer has fired. When the timer | 84 // Send an updated PageLoadTiming before the timer has fired. When the timer |
84 // fires, the updated PageLoadTiming should be sent. | 85 // fires, the updated PageLoadTiming should be sent. |
85 timing.document_timing->load_event_start = load_event; | 86 timing.document_timing->load_event_start = load_event; |
86 metrics_sender_->Send(timing.Clone()); | 87 metrics_sender_->Send(timing.Clone()); |
87 | 88 |
88 // Firing the timer should trigger sending of the SendTiming call with | 89 // Firing the timer should trigger sending of the OnTimingUpdated IPC with |
89 // the most recently provided PageLoadTiming instance. | 90 // the most recently provided PageLoadTiming instance. |
90 validator_.ExpectPageLoadTiming(timing); | 91 fake_ipc_sender_.ExpectPageLoadTiming(timing); |
91 metrics_sender_->mock_timer()->Fire(); | 92 metrics_sender_->mock_timer()->Fire(); |
92 EXPECT_FALSE(metrics_sender_->mock_timer()->IsRunning()); | 93 EXPECT_FALSE(metrics_sender_->mock_timer()->IsRunning()); |
93 } | 94 } |
94 | 95 |
95 TEST_F(PageTimingMetricsSenderTest, MultipleTimings) { | 96 TEST_F(PageTimingMetricsSenderTest, MultipleIPCs) { |
96 base::Time nav_start = base::Time::FromDoubleT(10); | 97 base::Time nav_start = base::Time::FromDoubleT(10); |
97 base::TimeDelta first_layout = base::TimeDelta::FromMillisecondsD(2); | 98 base::TimeDelta first_layout = base::TimeDelta::FromMillisecondsD(2); |
98 base::TimeDelta load_event = base::TimeDelta::FromMillisecondsD(4); | 99 base::TimeDelta load_event = base::TimeDelta::FromMillisecondsD(4); |
99 | 100 |
100 mojom::PageLoadTiming timing; | 101 mojom::PageLoadTiming timing; |
101 InitPageLoadTimingForTest(&timing); | 102 page_load_metrics::InitPageLoadTimingForTest(&timing); |
102 timing.navigation_start = nav_start; | 103 timing.navigation_start = nav_start; |
103 timing.document_timing->first_layout = first_layout; | 104 timing.document_timing->first_layout = first_layout; |
104 | 105 |
105 metrics_sender_->Send(timing.Clone()); | 106 metrics_sender_->Send(timing.Clone()); |
106 ASSERT_TRUE(metrics_sender_->mock_timer()->IsRunning()); | 107 ASSERT_TRUE(metrics_sender_->mock_timer()->IsRunning()); |
107 validator_.ExpectPageLoadTiming(timing); | 108 fake_ipc_sender_.ExpectPageLoadTiming(timing); |
108 metrics_sender_->mock_timer()->Fire(); | 109 metrics_sender_->mock_timer()->Fire(); |
109 EXPECT_FALSE(metrics_sender_->mock_timer()->IsRunning()); | 110 EXPECT_FALSE(metrics_sender_->mock_timer()->IsRunning()); |
110 validator_.VerifyExpectedTimings(); | 111 fake_ipc_sender_.VerifyExpectedTimings(); |
111 | 112 |
112 // Send an updated PageLoadTiming after the timer for the first send request | 113 // Send an updated PageLoadTiming after the timer for the first send request |
113 // has fired, and verify that a second timing is sent. | 114 // has fired, and verify that a second IPC is sent. |
114 timing.document_timing->load_event_start = load_event; | 115 timing.document_timing->load_event_start = load_event; |
115 metrics_sender_->Send(timing.Clone()); | 116 metrics_sender_->Send(timing.Clone()); |
116 ASSERT_TRUE(metrics_sender_->mock_timer()->IsRunning()); | 117 ASSERT_TRUE(metrics_sender_->mock_timer()->IsRunning()); |
117 validator_.ExpectPageLoadTiming(timing); | 118 fake_ipc_sender_.ExpectPageLoadTiming(timing); |
118 metrics_sender_->mock_timer()->Fire(); | 119 metrics_sender_->mock_timer()->Fire(); |
119 EXPECT_FALSE(metrics_sender_->mock_timer()->IsRunning()); | 120 EXPECT_FALSE(metrics_sender_->mock_timer()->IsRunning()); |
120 } | 121 } |
121 | 122 |
122 TEST_F(PageTimingMetricsSenderTest, SendTimingOnDestructor) { | 123 TEST_F(PageTimingMetricsSenderTest, SendIPCOnDestructor) { |
123 mojom::PageLoadTiming timing; | 124 mojom::PageLoadTiming timing; |
124 InitPageLoadTimingForTest(&timing); | 125 page_load_metrics::InitPageLoadTimingForTest(&timing); |
125 timing.navigation_start = base::Time::FromDoubleT(10); | 126 timing.navigation_start = base::Time::FromDoubleT(10); |
126 timing.document_timing->first_layout = base::TimeDelta::FromMilliseconds(10); | 127 timing.document_timing->first_layout = base::TimeDelta::FromMilliseconds(10); |
127 | 128 |
128 // This test wants to verify behavior in the PageTimingMetricsSender | 129 // This test wants to verify behavior in the PageTimingMetricsSender |
129 // destructor. The EXPECT_CALL will be satisfied when the |metrics_sender_| | 130 // destructor. The EXPECT_CALL will be satisfied when the |metrics_sender_| |
130 // is destroyed below. | 131 // is destroyed below. |
131 metrics_sender_->Send(timing.Clone()); | 132 metrics_sender_->Send(timing.Clone()); |
132 validator_.ExpectPageLoadTiming(timing); | 133 fake_ipc_sender_.ExpectPageLoadTiming(timing); |
133 ASSERT_TRUE(metrics_sender_->mock_timer()->IsRunning()); | 134 ASSERT_TRUE(metrics_sender_->mock_timer()->IsRunning()); |
134 | 135 |
135 // Destroy |metrics_sender_|, in order to force its destructor to run. | 136 // Destroy |metrics_sender_|, in order to force its destructor to run. |
136 metrics_sender_.reset(); | 137 metrics_sender_.reset(); |
137 } | 138 } |
138 | 139 |
139 } // namespace page_load_metrics | 140 } // namespace page_load_metrics |
OLD | NEW |