Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: chrome/browser/permissions/permission_request.h

Issue 2897223002: Fix message text for modal prompts when PermissionRequestManager enabled (Closed)
Patch Set: add mic/cam in switch Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_request.h
diff --git a/chrome/browser/permissions/permission_request.h b/chrome/browser/permissions/permission_request.h
index 748313efd9606d90f1ef7a5867d43fe10b98965d..01307e751bc4e555538a20785f04a04b0fdc4f92 100644
--- a/chrome/browser/permissions/permission_request.h
+++ b/chrome/browser/permissions/permission_request.h
@@ -76,6 +76,9 @@ class PermissionRequest {
// The icon to use next to the message text fragment in the permission bubble.
virtual IconId GetIconId() const = 0;
+ // Returns the full prompt text for this permission.
raymes 2017/05/29 04:48:27 Can we make a note that this is only currently use
Timothy Loh 2017/05/30 05:02:34 Done
+ virtual base::string16 GetMessageText() const = 0;
+
// Returns the shortened prompt text for this permission. Must be phrased
// as a heading, e.g. "Location", or "Camera". The permission bubble may
// coalesce different requests, and if it does, this text will be displayed

Powered by Google App Engine
This is Rietveld 408576698