chrome/browser/media/webrtc/media_stream_devices_controller.h - Issue 2897223002: Fix message text for modal prompts when PermissionRequestManager enabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/webrtc/media_stream_devices_controller.h

Issue 2897223002: Fix message text for modal prompts when PermissionRequestManager enabled (Closed)

Patch Set: add mic/cam in switch Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/media/webrtc/media_stream_devices_controller.h

diff --git a/chrome/browser/media/webrtc/media_stream_devices_controller.h b/chrome/browser/media/webrtc/media_stream_devices_controller.h

index a8348c162b8eb9f2ca12439ed5890da9ec65d452..6679956223b581d671ad833ae852bafb4b18f635 100644

--- a/chrome/browser/media/webrtc/media_stream_devices_controller.h

+++ b/chrome/browser/media/webrtc/media_stream_devices_controller.h

@@ -52,7 +52,7 @@ class MediaStreamDevicesController {

bool IsAskingForAudio() const;

bool IsAskingForVideo() const;

- base::string16 GetMessageText() const;

+ base::string16 GetMessageText() const override;

raymes 2017/05/29 04:48:27 nit: this should move down with the other override

Timothy Loh 2017/05/30 05:02:34 Moved here and in the .cc

// PermissionRequest:

IconId GetIconId() const override;