Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: chrome/browser/permissions/permission_dialog_delegate.cc

Issue 2897223002: Fix message text for modal prompts when PermissionRequestManager enabled (Closed)
Patch Set: add mic/cam in switch Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_dialog_delegate.cc
diff --git a/chrome/browser/permissions/permission_dialog_delegate.cc b/chrome/browser/permissions/permission_dialog_delegate.cc
index 97a4da467854414b5123bbfb3ed4fe298a47ada7..8628269b509bd3bf05b7b9633ce316c5c63f3912 100644
--- a/chrome/browser/permissions/permission_dialog_delegate.cc
+++ b/chrome/browser/permissions/permission_dialog_delegate.cc
@@ -157,9 +157,7 @@ void PermissionDialogDelegate::CreateJavaDelegate(JNIEnv* env) {
base::android::ToJavaIntArray(env, content_settings_types).obj(),
ResourceMapper::MapFromChromiumId(
permission_prompt_->GetIconIdForPermission(0)),
- // TODO(timloh): This is the wrong string.
- ConvertUTF16ToJavaString(env,
- permission_prompt_->GetMessageTextFragment(0)),
+ ConvertUTF16ToJavaString(env, permission_prompt_->GetMessageText(0)),
// TODO(timloh): Pass the actual link text for EME.
ConvertUTF16ToJavaString(env, base::string16()), primaryButtonText,
secondaryButtonText,

Powered by Google App Engine
This is Rietveld 408576698