[Turbofan] Remove UnallocatedOperand::set_virtual_register.

[Turbofan] Remove UnallocatedOperand::set_virtual_register.
- Removes set_virtual_register method. InstructionOperands are immutable.
- Adds a new ctor to copy an UnallocatedOperand with a new vreg.
- Removes some DCHECKs in UnallocatedOperand that are always true. To
  make sure, make UnallocatedOperand final.
- Cleans up some comments on UnallocatedOperand Lifetime enum.

BUG=v8:6325
Review-Url: https://codereview.chromium.org/2897203002
Cr-Commit-Position: refs/heads/master@{#45533}
Committed: https://chromium.googlesource.com/v8/v8/+/5dde8b312bfbdefdfeeb95fa3f3030ebe2b9529d

[bbudge, 2017-05-24 00:25:50]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 00:26:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 00:54:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 00:54:07]

Dry run: This issue passed the CQ dry run.

[bbudge, 2017-05-24 02:11:52]

bbudge@chromium.org changed reviewers:
+ mtrofin@chromium.org

[Mircea Trofin, 2017-05-24 07:00:22]

On 2017/05/24 02:11:52, bbudge wrote:

lgtm, 1 nit

[Mircea Trofin, 2017-05-24 07:00:46]

lgtm, 1 nit

https://codereview.chromium.org/2897203002/diff/1/src/compiler/instruction.h
File src/compiler/instruction.h (right):

https://codereview.chromium.org/2897203002/diff/1/src/compiler/instruction.h#...
src/compiler/instruction.h:235: UnallocatedOperand(const UnallocatedOperand*
other, int virtual_register) {
You can pass other as a const UnallocatedOperand&, which also means it won't be
null.

[bbudge, 2017-05-24 16:11:25]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 16:11:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bbudge, 2017-05-24 16:12:04]

https://codereview.chromium.org/2897203002/diff/1/src/compiler/instruction.h
File src/compiler/instruction.h (right):

https://codereview.chromium.org/2897203002/diff/1/src/compiler/instruction.h#...
src/compiler/instruction.h:235: UnallocatedOperand(const UnallocatedOperand*
other, int virtual_register) {
On 2017/05/24 07:00:46, Mircea Trofin wrote:
> You can pass other as a const UnallocatedOperand&, which also means it won't
be
> null.

Much better, thanks.

[commit-bot: I haz the power, 2017-05-24 16:40:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 16:40:05]

Dry run: This issue passed the CQ dry run.

[bbudge, 2017-05-25 18:30:10]

The CQ bit was checked by bbudge@chromium.org

[bbudge, 2017-05-25 18:30:10]

The patchset sent to the CQ was uploaded after l-g-t-m from mtrofin@chromium.org
Link to the patchset: https://codereview.chromium.org/2897203002/#ps20001
(title: "Make ctor conform to Chromium style.")

[commit-bot: I haz the power, 2017-05-25 18:30:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 18:59:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495737010403960,
"parent_rev": "0c6c3974fe630bdf63bea1489ef33f044661bf4d", "commit_rev":
"5dde8b312bfbdefdfeeb95fa3f3030ebe2b9529d"}

[commit-bot: I haz the power, 2017-05-25 18:59:36]

Description was changed from

==========
[Turbofan] Remove UnallocatedOperand::set_virtual_register.
- Removes set_virtual_register method. InstructionOperands are immutable.
- Adds a new ctor to copy an UnallocatedOperand with a new vreg.
- Removes some DCHECKs in UnallocatedOperand that are always true. To
  make sure, make UnallocatedOperand final.
- Cleans up some comments on UnallocatedOperand Lifetime enum.

BUG=v8:6325
==========

to

==========
[Turbofan] Remove UnallocatedOperand::set_virtual_register.
- Removes set_virtual_register method. InstructionOperands are immutable.
- Adds a new ctor to copy an UnallocatedOperand with a new vreg.
- Removes some DCHECKs in UnallocatedOperand that are always true. To
  make sure, make UnallocatedOperand final.
- Cleans up some comments on UnallocatedOperand Lifetime enum.

BUG=v8:6325

Review-Url: https://codereview.chromium.org/2897203002
Cr-Commit-Position: refs/heads/master@{#45533}
Committed:
https://chromium.googlesource.com/v8/v8/+/5dde8b312bfbdefdfeeb95fa3f3030ebe2b...
==========

[commit-bot: I haz the power, 2017-05-25 18:59:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/5dde8b312bfbdefdfeeb95fa3f3030ebe2b...