Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5

Issue 2897193005: Generate diffs for all fields on StyleRareInheritedData (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5
diff --git a/third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5 b/third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5
index 5d226d7c1b39674975465214a8e4ca0f1137dc99..e528343c305ffafe74f41cdbb7130d4a5c5ec11a 100644
--- a/third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5
+++ b/third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5
@@ -45,7 +45,7 @@
{
name: "DiffNeedsFullLayoutAndPaintInvalidation",
fields_to_diff: ["padding-top", "padding-left", "padding-right",
- "padding-bottom", "line-height", "font", "-webkit-border-horizontal-spacing", "-webkit-border-vertical-spacing", "TextAutosizingMultiplier"],
+ "padding-bottom", "-webkit-highlight", "text-indent", "text-align-last", "TextIndentLine", "EffectiveZoom", "word-break", "overflow-wrap", "-webkit-line-break", "-webkit-text-security", "hyphens", "HyphenationLimitBefore", "HyphenationLimitAfter", "-webkit-hyphenate-character", "RespectImageOrientation", "-webkit-ruby-position", "TextEmphasisMark", "TextEmphasisPosition", "TextEmphasisCustomMark", "text-justify", "text-orientation", "text-combine-upright", "tab-size", "text-size-adjust", "list-style-image", "line-height-step", "-webkit-text-stroke-width", "line-height", "font", "-webkit-border-horizontal-spacing", "-webkit-border-vertical-spacing", "TextAutosizingMultiplier"],
methods_to_diff: [
{
method: "BorderLeftWidth()",
@@ -136,11 +136,46 @@
]
},
{
+ name: "DiffNeedsFullLayoutAndPaintInvalidationDisplayTableType",
+ methods_to_diff: [
+ {
+ method: "BorderCollapse()",
+ field_dependencies: ["border-collapse"]
+ },
+ {
+ method: "EmptyCells()",
+ field_dependencies: ["empty-cells"]
+ },
+ {
+ method: "CaptionSide()",
+ field_dependencies: ["caption-side"]
+ },
+ {
+ method: "TableLayout()",
+ field_dependencies: ["table-layout"]
+ },
+ ]
+ },
+ {
+ name: "DiffNeedsFullLayoutAndPaintInvalidationDisplayListItem",
+ methods_to_diff: [
+ {
+ method: "ListStyleType()",
+ field_dependencies: ["list-style-type"]
+ },
+ {
+ method: "ListStylePosition()",
+ field_dependencies: ["list-style-position"]
+ },
+ ]
+ },
+ {
name: "DiffNeedsFullLayout",
fields_to_diff: ["width", "min-width", "max-width", "height", "min-height", "max-height", "box-sizing"]
},
{
name: "DiffNeedsPaintInvalidationObject",
+ fields_to_diff: ["-webkit-user-modify", "user-select", "image-rendering"],
methods_to_diff: [
{
method: "Visibility()",
@@ -164,6 +199,44 @@
field_dependencies: ["visibility"]
}
]
- }
+ },
+ {
+ name: "UpdatePropertySpecificDifferencesTextDecorationOrColor",
+ fields_to_diff: ["TextEmphasisFill", "text-underline-position", "text-decoration-skip", "AppliedTextDecorations"],
+ methods_to_diff: [
+ {
+ method: "TextFillColor()",
+ field_dependencies: ["-webkit-text-fill-color"]
+ },
+ {
+ method: "TextStrokeColor()",
+ field_dependencies: ["-webkit-text-stroke-color"]
+ },
+ {
+ method: "TextEmphasisColor()",
+ field_dependencies: ["-webkit-text-emphasis-color"]
+ },
+ {
+ method: "VisitedLinkTextFillColor()",
+ field_dependencies: ["VisitedLinkTextFillColor"]
+ },
+ {
+ method: "VisitedLinkTextStrokeColor()",
+ field_dependencies: ["VisitedLinkTextStrokeColor"]
+ },
+ {
+ method: "VisitedLinkTextEmphasisColor()",
+ field_dependencies: ["VisitedLinkTextEmphasisColor"]
+ },
+ {
+ method: "CaretColor()",
+ field_dependencies: ["caret-color"]
+ },
+ {
+ method: "VisitedLinkCaretColor()",
+ field_dependencies: ["VisitedLinkCaretColor"]
+ },
+ ]
+ },
],
}

Powered by Google App Engine
This is Rietveld 408576698