Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2897193003: DevTools: Fix up CSSMetadata for 2017 (Closed)

Created:
3 years, 7 months ago by einbinder
Modified:
3 years, 7 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Fix up CSSMetadata for 2017 This patch removes some now-unsupported css values, adds some new values, and adds new properties. BUG=716501 Review-Url: https://codereview.chromium.org/2897193003 Cr-Commit-Position: refs/heads/master@{#474496} Committed: https://chromium.googlesource.com/chromium/src/+/14b8cc4e3063e2de20eed87b6cc22ecee092f869

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+448 lines, -94 lines) Patch
M third_party/WebKit/LayoutTests/inspector/sources/autocomplete-css-expected.txt View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/autocomplete-scss-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js View 20 chunks +443 lines, -89 lines 4 comments Download

Messages

Total messages: 8 (4 generated)
einbinder
This was a semi-automated process, so there might be typos. https://codereview.chromium.org/2897193003/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js File third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js (left): https://codereview.chromium.org/2897193003/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js#oldcode475 ...
3 years, 7 months ago (2017-05-24 04:55:43 UTC) #2
pfeldman
lgtm
3 years, 7 months ago (2017-05-24 19:00:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897193003/1
3 years, 7 months ago (2017-05-24 19:58:52 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 00:42:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/14b8cc4e3063e2de20eed87b6cc2...

Powered by Google App Engine
This is Rietveld 408576698