Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2897173003: [DevTools] Simplify selection restoration logic (Closed)

Created:
3 years, 7 months ago by eostroukhov
Modified:
3 years, 7 months ago
Reviewers:
caseq, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Simplify selection restoration logic The flag is unnecessary - it is much more reliable to always attempt restoring the selection. BUG=683704 Review-Url: https://codereview.chromium.org/2897173003 Cr-Commit-Position: refs/heads/master@{#474418} Committed: https://chromium.googlesource.com/chromium/src/+/8aa8d88b844c6e9f5230d4a60a4a5b8a41e1a536

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js View 4 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
eostroukhov
3 years, 7 months ago (2017-05-23 22:11:57 UTC) #3
eostroukhov
3 years, 7 months ago (2017-05-24 18:09:19 UTC) #8
caseq
lgtm
3 years, 7 months ago (2017-05-24 20:46:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897173003/1
3 years, 7 months ago (2017-05-24 20:50:30 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 20:56:49 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8aa8d88b844c6e9f5230d4a60a4a...

Powered by Google App Engine
This is Rietveld 408576698