Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 2897163002: Fixed bugs with finding line boundaries using IA2 get_textAtOffset and AXPosition::AtStartOfLine. (Closed)

Created:
3 years, 7 months ago by nektarios
Modified:
3 years, 7 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, aleventhal
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed bugs with finding line boundaries using IA2 get_textAtOffset and AXPosition::AtStartOfLine. 1. AXPosition can handle offsets at the end of text, so no need to do "--offset" in get_textAtOffset when offset == text length. 2. The end boundary should be found based on the start boundary, not based on the original offset to error-out for situations when both the start and end boundaries are before the original offset. 3. AXPosition::AtStartOfLine should report |true| for text positions that are right after a newline when that newline is before some text. This is because visually the position is at the start of a new line. In practice this situation only occurs at the end of a text field. 4. COM return values should be set to defaults (0 and nullptr) when the operation fails. BUG=725629 R=dmazzoni@chromium.org CC=aleventhal@chromium.org TESTED=manually with Jaws, unit tests Review-Url: https://codereview.chromium.org/2897163002 Cr-Commit-Position: refs/heads/master@{#474861} Committed: https://chromium.googlesource.com/chromium/src/+/21b5bb81bf3acaad3f32f53950b4aeb1496724d7

Patch Set 1 #

Patch Set 2 : Fixed bugs with finding line boundaries using IA2 get_textAtOffset. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -48 lines) Patch
M content/browser/accessibility/browser_accessibility_com_win.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_com_win.cc View 1 6 chunks +40 lines, -42 lines 0 comments Download
M ui/accessibility/ax_node_position_unittest.cc View 1 3 chunks +76 lines, -2 lines 0 comments Download
M ui/accessibility/ax_position.h View 1 chunk +9 lines, -2 lines 1 comment Download

Messages

Total messages: 15 (11 generated)
nektarios
3 years, 7 months ago (2017-05-23 20:40:11 UTC) #1
dmazzoni
lgtm https://codereview.chromium.org/2897163002/diff/20001/ui/accessibility/ax_position.h File ui/accessibility/ax_position.h (right): https://codereview.chromium.org/2897163002/diff/20001/ui/accessibility/ax_position.h#newcode595 ui/accessibility/ax_position.h:595: if ((text_position->text_offset_ + 1) < text_position->MaxTextOffset()) { David ...
3 years, 7 months ago (2017-05-25 21:28:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897163002/20001
3 years, 7 months ago (2017-05-26 01:03:28 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 01:11:22 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/21b5bb81bf3acaad3f32f53950b4...

Powered by Google App Engine
This is Rietveld 408576698