Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2897133002: Revert of [WebPayments] Adding FilterProfilesForShipping to profile comparator (Closed)

Created:
3 years, 7 months ago by Marijn Kruisselbrink
Modified:
3 years, 7 months ago
Reviewers:
Mathieu, tmartino, Moe
CC:
chromium-reviews, darin-cc_chromium.org, gogerald+paymentswatch_chromium.org, jam, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [WebPayments] Adding FilterProfilesForShipping to profile comparator (patchset #5 id:80001 of https://codereview.chromium.org/2884393002/ ) Reason for revert: Appears to be causing test failures in https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin10_Tests_x64%2F11929%2F%2B%2Frecipes%2Fsteps%2Fbrowser_side_navigation_browser_tests_on_Windows-10-10586%2F0%2Flogs%2FPaymentRequestProfileListTest.PrioritizeCompleteness%2F0 RUN ] PaymentRequestProfileListTest.PrioritizeCompleteness [640:3644:0523/102806.488:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico c:\b\c\b\win\src\chrome\browser\ui\views\payments\profile_list_view_controller_browsertest.cc(46): error: Expected: partial Which is: b5e544d1-6a66-49bf-bd4c-f2eb38671fd3 https://www.example.com/ Jane A. Smith jsmith@example.com ACME 48838 US 13105557889 To be equal to: *profiles[0] Which is: 63b73e74-aacb-4a0e-bde5-a3260918586c http://www.example.com/ John H. Doe johndoe@hades.com Underworld 666 Erebus St. Apt 8 Elysium CA 91111 US 16502111111 c:\b\c\b\win\src\chrome\browser\ui\views\payments\profile_list_view_controller_browsertest.cc(47): error: Expected: complete Which is: 63b73e74-aacb-4a0e-bde5-a3260918586c http://www.example.com/ John H. Doe johndoe@hades.com Underworld 666 Erebus St. Apt 8 Elysium CA 91111 US 16502111111 To be equal to: *profiles[1] Which is: b5e544d1-6a66-49bf-bd4c-f2eb38671fd3 https://www.example.com/ Jane A. Smith jsmith@example.com ACME 48838 US 13105557889 [ FAILED ] PaymentRequestProfileListTest.PrioritizeCompleteness, where TypeParam = and GetParam() = (1292 ms) Original issue's description: > [WebPayments] Adding FilterProfilesForShipping to profile comparator > > BUG=722949 > > Review-Url: https://codereview.chromium.org/2884393002 > Cr-Commit-Position: refs/heads/master@{#473929} > Committed: https://chromium.googlesource.com/chromium/src/+/eb8d574b98adfcbd3b5ce2eb6e521b83efbb428a TBR=mahmadi@chromium.org,mathp@chromium.org,tmartino@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=722949 Review-Url: https://codereview.chromium.org/2897133002 Cr-Commit-Position: refs/heads/master@{#473982} Committed: https://chromium.googlesource.com/chromium/src/+/427e841ab562c51ccae522bb9149cc5c5c680aa1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -273 lines) Patch
M chrome/browser/ui/views/payments/contact_info_editor_view_controller_browsertest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
D chrome/browser/ui/views/payments/profile_list_view_controller_browsertest.cc View 1 chunk +0 lines, -78 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/payments/content/payment_request_state.cc View 2 chunks +23 lines, -14 lines 0 comments Download
M components/payments/core/payments_profile_comparator.h View 2 chunks +8 lines, -20 lines 0 comments Download
M components/payments/core/payments_profile_comparator.cc View 3 chunks +9 lines, -42 lines 0 comments Download
M components/payments/core/payments_profile_comparator_unittest.cc View 1 chunk +0 lines, -97 lines 0 comments Download
M ios/chrome/browser/payments/payment_request.mm View 1 chunk +17 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Marijn Kruisselbrink
Created Revert of [WebPayments] Adding FilterProfilesForShipping to profile comparator
3 years, 7 months ago (2017-05-23 18:14:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897133002/1
3 years, 7 months ago (2017-05-23 18:15:37 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 18:17:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/427e841ab562c51ccae522bb9149...

Powered by Google App Engine
This is Rietveld 408576698