Move display_service_unittests to services_unittests.

Move display_service_unittests to services_unittests.

This adapts the service_test.gni template to take an optional test runner
target which overrides the default services_manager test runner. It also
reorganizes the service_manager test runner to be modular so tests can use
their own base::TestSuite subclass while still using the rest of the
initialization that run_all_service_tests provided.

BUG=722546
Review-Url: https://codereview.chromium.org/2897123004
Cr-Commit-Position: refs/heads/master@{#474740}
Committed: https://chromium.googlesource.com/chromium/src/+/8ce908eea615191798b109b4d67ce267421b69f6

[Elliot Glaysher, 2017-05-23 21:23:02]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 21:24:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-05-23 21:39:49]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 21:40:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 23:03:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 23:03:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Elliot Glaysher, 2017-05-23 23:04:28]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 23:05:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 23:46:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 23:46:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Elliot Glaysher, 2017-05-23 23:48:54]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 23:50:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 04:01:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 04:01:43]

Dry run: This issue passed the CQ dry run.

[Elliot Glaysher, 2017-05-24 17:10:43]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 17:11:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-05-24 18:21:06]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 18:22:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-05-24 19:30:09]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 19:30:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-05-24 20:08:04]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 20:08:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 20:17:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 20:17:11]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Elliot Glaysher, 2017-05-24 21:32:44]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 21:33:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-05-24 22:02:27]

erg@chromium.org changed reviewers:
+ sky@chromium.org

[Elliot Glaysher, 2017-05-24 22:02:28]

https://codereview.chromium.org/2897123004/diff/160001/services/service_manag...
File services/service_manager/public/tools/test/service_test.gni (right):

https://codereview.chromium.org/2897123004/diff/160001/services/service_manag...
services/service_manager/public/tools/test/service_test.gni:33: if
(defined(invoker.test_runner)) {
This it the thing that I'm not sure about. This lets a service_test() declare
what target it wants to use as a test runner. If not specified, it'll use the
default service_manager test runner.

[sky, 2017-05-24 22:34:10]

sky@chromium.org changed reviewers:
+ rockot@chromium.org

[sky, 2017-05-24 22:34:11]

Ken should review this as I'm not familiar with
services/service_manager/public/tools/test/service_test.gni . It looks right,
but Ken knows better.

The rest LGTM

https://codereview.chromium.org/2897123004/diff/160001/services/service_manag...
File services/service_manager/public/cpp/test/BUILD.gn (right):

https://codereview.chromium.org/2897123004/diff/160001/services/service_manag...
services/service_manager/public/cpp/test/BUILD.gn:32: # NOTE: Don't depend on
this target directly. Instead use the service_test
Is it possible to enforce this with visibility?

[Elliot Glaysher, 2017-05-24 22:42:09]

https://codereview.chromium.org/2897123004/diff/160001/services/service_manag...
File services/service_manager/public/cpp/test/BUILD.gn (right):

https://codereview.chromium.org/2897123004/diff/160001/services/service_manag...
services/service_manager/public/cpp/test/BUILD.gn:32: # NOTE: Don't depend on
this target directly. Instead use the service_test
On 2017/05/24 22:34:11, sky wrote:
> Is it possible to enforce this with visibility?

I don't believe it can. The visibility check happens after template expansion,
so if I add a visibility rule here on
"//services/service_manager/public/tools/test:*", I then get visibility failures
in the files which use the template.

[commit-bot: I haz the power, 2017-05-24 23:30:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 23:30:06]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2017-05-25 01:54:00]

lgtm

https://codereview.chromium.org/2897123004/diff/160001/services/service_manag...
File services/service_manager/public/cpp/test/common_initialization.h (right):

https://codereview.chromium.org/2897123004/diff/160001/services/service_manag...
services/service_manager/public/cpp/test/common_initialization.h:10: namespace
services {
For consistency with everything else here this should really be service_manager

[Elliot Glaysher, 2017-05-25 17:16:11]

The CQ bit was checked by erg@chromium.org

[Elliot Glaysher, 2017-05-25 17:16:11]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2897123004/#ps180001
(title: "services -> service_manager")

[commit-bot: I haz the power, 2017-05-25 17:16:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 19:06:17]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1495732571494380,
"parent_rev": "2d123058c5e6ba14b52241c6d39fbbbeebece1bd", "commit_rev":
"8ce908eea615191798b109b4d67ce267421b69f6"}

[commit-bot: I haz the power, 2017-05-25 19:06:28]

Description was changed from

==========
Move display_service_unittests to services_unittests.

This adapts the service_test.gni template to take an optional test runner
target which overrides the default services_manager test runner. It also
reorganizes the service_manager test runner to be modular so tests can use
their own base::TestSuite subclass while still using the rest of the
initialization that run_all_service_tests provided.

BUG=722546
==========

to

==========
Move display_service_unittests to services_unittests.

This adapts the service_test.gni template to take an optional test runner
target which overrides the default services_manager test runner. It also
reorganizes the service_manager test runner to be modular so tests can use
their own base::TestSuite subclass while still using the rest of the
initialization that run_all_service_tests provided.

BUG=722546

Review-Url: https://codereview.chromium.org/2897123004
Cr-Commit-Position: refs/heads/master@{#474740}
Committed:
https://chromium.googlesource.com/chromium/src/+/8ce908eea615191798b109b4d67c...
==========

[commit-bot: I haz the power, 2017-05-25 19:06:29]

Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/8ce908eea615191798b109b4d67c...