Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Issue 2897113002: Remove duplicate service wrkr "shared worker" test (Closed)

Created:
3 years, 7 months ago by mike3
Modified:
3 years, 7 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, tfarina, serviceworker-reviews, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove duplicate service wrkr "shared worker" test This test is identical to the version available in the Web Platform Tests project and may therefore be removed without impacting coverage. BUG=688116 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2897113002 Cr-Commit-Position: refs/heads/master@{#475066} Committed: https://chromium.googlesource.com/chromium/src/+/35067fccc9e3904e01a9a650fc664ff8170446f2

Patch Set 1 #

Patch Set 2 : Re-introduce shared resource file #

Messages

Total messages: 15 (6 generated)
mike3
Here's the proof :) https://gist.github.com/jugglinmike/040cc59ef51bf30a96185dff35a70ce5
3 years, 7 months ago (2017-05-23 18:02:56 UTC) #1
falken
lgtm
3 years, 7 months ago (2017-05-26 01:21:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897113002/1
3 years, 7 months ago (2017-05-26 01:23:04 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/455012)
3 years, 7 months ago (2017-05-26 03:09:08 UTC) #6
mike3
On 2017/05/26 03:09:08, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 7 months ago (2017-05-26 14:38:28 UTC) #7
falken
On 2017/05/26 14:38:28, mike3 wrote: > On 2017/05/26 03:09:08, commit-bot: I haz the power wrote: ...
3 years, 7 months ago (2017-05-26 15:01:51 UTC) #8
mike3
On 2017/05/26 15:01:51, falken wrote: > Ah sorry. Look for "archive_webkit_tests_results" then "layout_test_results" > under ...
3 years, 7 months ago (2017-05-26 16:54:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897113002/20001
3 years, 7 months ago (2017-05-26 16:55:23 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 18:28:43 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/35067fccc9e3904e01a9a650fc66...

Powered by Google App Engine
This is Rietveld 408576698