Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2897103003: Fix some callsites of AddMarker() in InputMethodControllerTest (Closed)

Created:
3 years, 7 months ago by rlanday
Modified:
3 years, 7 months ago
Reviewers:
yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some callsites of AddMarker() in InputMethodControllerTest This AddMarker() method should really only be used for Spelling and Grammar markers (I'm going to split it into AddSpellingMarker() and AddGrammarMarker() in a later CL to eliminate this problem). This CL fixes some test cases that create TextMatch markers to use AddTextMatchMarker(). BUG=707867 Review-Url: https://codereview.chromium.org/2897103003 Cr-Commit-Position: refs/heads/master@{#474463} Committed: https://chromium.googlesource.com/chromium/src/+/1d54305bd8f1dc8b62398e229603dfd4165e1447

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -60 lines) Patch
M third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp View 1 12 chunks +40 lines, -60 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
rlanday
3 years, 7 months ago (2017-05-23 19:00:46 UTC) #3
Xiaocheng
lgtm Bot failures don't seem relevant.
3 years, 7 months ago (2017-05-24 05:21:52 UTC) #7
yosin_UTC9
lgtm Thanks!
3 years, 7 months ago (2017-05-24 09:01:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897103003/20001
3 years, 7 months ago (2017-05-24 21:32:51 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 23:02:32 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1d54305bd8f1dc8b62398e229603...

Powered by Google App Engine
This is Rietveld 408576698