|
|
Chromium Code Reviews
DescriptionFix some callsites of AddMarker() in InputMethodControllerTest
This AddMarker() method should really only be used for Spelling and Grammar
markers (I'm going to split it into AddSpellingMarker() and AddGrammarMarker()
in a later CL to eliminate this problem). This CL fixes some test cases that
create TextMatch markers to use AddTextMatchMarker().
BUG=707867
Review-Url: https://codereview.chromium.org/2897103003
Cr-Commit-Position: refs/heads/master@{#474463}
Committed: https://chromium.googlesource.com/chromium/src/+/1d54305bd8f1dc8b62398e229603dfd4165e1447
Patch Set 1 #Patch Set 2 : Rebase #Messages
Total messages: 17 (12 generated)
The CQ bit was checked by rlanday@chromium.org to run a CQ dry run
rlanday@chromium.org changed reviewers: + xiaochengh@chromium.org, yosin@chromium.org
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm Bot failures don't seem relevant.
lgtm Thanks!
The CQ bit was checked by rlanday@chromium.org to run a CQ dry run
The CQ bit was unchecked by rlanday@chromium.org
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by rlanday@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org, xiaochengh@chromium.org Link to the patchset: https://codereview.chromium.org/2897103003/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495661514731510,
"parent_rev": "8fb4b9b1913bdda4ad9a3fba78d2f73fbf52ff0f", "commit_rev":
"1d54305bd8f1dc8b62398e229603dfd4165e1447"}
Message was sent while issue was closed.
Description was changed from ========== Fix some callsites of AddMarker() in InputMethodControllerTest This AddMarker() method should really only be used for Spelling and Grammar markers (I'm going to split it into AddSpellingMarker() and AddGrammarMarker() in a later CL to eliminate this problem). This CL fixes some test cases that create TextMatch markers to use AddTextMatchMarker(). BUG=707867 ========== to ========== Fix some callsites of AddMarker() in InputMethodControllerTest This AddMarker() method should really only be used for Spelling and Grammar markers (I'm going to split it into AddSpellingMarker() and AddGrammarMarker() in a later CL to eliminate this problem). This CL fixes some test cases that create TextMatch markers to use AddTextMatchMarker(). BUG=707867 Review-Url: https://codereview.chromium.org/2897103003 Cr-Commit-Position: refs/heads/master@{#474463} Committed: https://chromium.googlesource.com/chromium/src/+/1d54305bd8f1dc8b62398e229603... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/1d54305bd8f1dc8b62398e229603... |
