DevTools: introduce setting to filter only user messages from console API

DevTools: introduce setting to filter only user messages from console API

Introduces the setting to show only console API messages, and makes the similar
"show selected context only" checkbox a setting as well.

BUG=717776
Review-Url: https://codereview.chromium.org/2897033005
Cr-Commit-Position: refs/heads/master@{#474159}
Committed: https://chromium.googlesource.com/chromium/src/+/7907e899eacebaa677937ba90066b34822e4b44e

[luoe, 2017-05-23 18:25:56]

luoe@chromium.org changed reviewers:
+ pfeldman@chromium.org

[luoe, 2017-05-23 18:25:57]

Not looking for review.  This is just a CL exploring a checkbox to only show
messages that come from console.* methods when enabled.  Commands/evaluations
still kept.

[pfeldman, 2017-05-23 18:59:26]

https://codereview.chromium.org/2897033005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
(right):

https://codereview.chromium.org/2897033005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:1004:
this._filterConsoleAPICheckbox = new UI.ToolbarCheckbox(
Convert it into a setting for consistency and assign the 717776 bug.

[luoe, 2017-05-23 19:23:00]

Description was changed from

==========
User messages only (console.*)

BUG=none
==========

to

==========
DevTools: introduce setting to filter only user messages from console API

Introduces the setting to show only console API messages, and makes the similar
"show selected context only" checkbox a setting as well.

BUG=717776
==========

[luoe, 2017-05-23 20:28:51]

Ptal

https://codereview.chromium.org/2897033005/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
(right):

https://codereview.chromium.org/2897033005/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:1004:
this._filterConsoleAPICheckbox = new UI.ToolbarCheckbox(
On 2017/05/23 18:59:26, pfeldman wrote:
> Convert it into a setting for consistency and assign the 717776 bug.

Done.  'selected context only' was also wasn't a setting, and it would be
strange for it to be the only checkbox that wasn't persisted.

[pfeldman, 2017-05-23 20:56:32]

https://codereview.chromium.org/2897033005/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html
(right):

https://codereview.chromium.org/2897033005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html:10:
var filterByExecutionContextSetting =
Common.moduleSetting('selectedContextFilterEnabled');
console.selected...

https://codereview.chromium.org/2897033005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
(right):

https://codereview.chromium.org/2897033005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:89:
Common.UIString('Only show messages from the current context (top, iframe,
worker, extension)'),
Do we need to repeat these captions in addition to the module.json one?

https://codereview.chromium.org/2897033005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:92:
Common.moduleSetting('consoleAPIFilterEnabled'), Common.UIString('Only show
messages from console.* methods'),
ditto

https://codereview.chromium.org/2897033005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/module.json (right):

https://codereview.chromium.org/2897033005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/module.json:84:
"settingName": "selectedContextFilterEnabled",
Let's make both 'session' for now.

[luoe, 2017-05-23 21:03:45]

Ptal

https://codereview.chromium.org/2897033005/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html
(right):

https://codereview.chromium.org/2897033005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html:10:
var filterByExecutionContextSetting =
Common.moduleSetting('selectedContextFilterEnabled');
On 2017/05/23 20:56:32, pfeldman wrote:
> console.selected...

Done.

https://codereview.chromium.org/2897033005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
(right):

https://codereview.chromium.org/2897033005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:89:
Common.UIString('Only show messages from the current context (top, iframe,
worker, extension)'),
On 2017/05/23 20:56:32, pfeldman wrote:
> Do we need to repeat these captions in addition to the module.json one?

I should make them consistent.  They're only repeated in the module.json so that
command menu sees them.

https://codereview.chromium.org/2897033005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/module.json (right):

https://codereview.chromium.org/2897033005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/module.json:84:
"settingName": "selectedContextFilterEnabled",
On 2017/05/23 20:56:32, pfeldman wrote:
> Let's make both 'session' for now.

Done.

[pfeldman, 2017-05-23 21:13:05]

lgtm

[luoe, 2017-05-23 21:13:25]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2017-05-23 21:14:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 00:50:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 00:51:02]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[luoe, 2017-05-24 00:54:19]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2017-05-24 00:55:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 04:15:39]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495587259437850,
"parent_rev": "23da751ab184c42ed88c67e150c316878105211e", "commit_rev":
"7907e899eacebaa677937ba90066b34822e4b44e"}

[commit-bot: I haz the power, 2017-05-24 04:15:52]

Description was changed from

==========
DevTools: introduce setting to filter only user messages from console API

Introduces the setting to show only console API messages, and makes the similar
"show selected context only" checkbox a setting as well.

BUG=717776
==========

to

==========
DevTools: introduce setting to filter only user messages from console API

Introduces the setting to show only console API messages, and makes the similar
"show selected context only" checkbox a setting as well.

BUG=717776

Review-Url: https://codereview.chromium.org/2897033005
Cr-Commit-Position: refs/heads/master@{#474159}
Committed:
https://chromium.googlesource.com/chromium/src/+/7907e899eacebaa677937ba90066...
==========

[commit-bot: I haz the power, 2017-05-24 04:15:52]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7907e899eacebaa677937ba90066...