Debian package: Add lsb-release to deps

Debian package: Add lsb-release to deps

The Debian package had a dependency on lsb-base [1], which doesn't
actually add any usable utilities, and is just a dependency required
by other lsb utils.  I believe the intention was to add a dependency
on 'lsb', which adds a bunch of (unnecessary) stuff.

Chrome uses lsb_release (in base/linux_util), so a direct dependency
on 'lsb-release' is added.  The RPM packge doesn't have this problem
because it depends on 'lsb', which pulls in lsb-release.

[1] https://packages.ubuntu.com/xenial/lsb-base

BUG=724244
R=thestig@chromium.org,timbrown@chromium.org

Review-Url: https://codereview.chromium.org/2897033004
Cr-Commit-Position: refs/heads/master@{#474078}
Committed: https://chromium.googlesource.com/chromium/src/+/1a4c9a8ed39d4b4ce648487981b1b53da4c3c0ea

[Tom Anderson, 2017-05-23 17:59:45]

Description was changed from

==========
Debian package: Add lsb-release to deps

The Debian package had a dependency on lsb-base [1], which doesn't
actually add any usable utilities, and is just a dependency required
by other lsb utils.

Chrome uses lsb_release, so a direct dependency on 'lsb-release' is
added.  The RPM packge doesn't have this problem because it depends on
'lsb', which pulls in lsb-release.

[1] https://packages.ubuntu.com/xenial/lsb-base

BUG=724244
R=thestig@chromium.org,timbrown@chromium.org
==========

to

==========
Debian package: Add lsb-release to deps

The Debian package had a dependency on lsb-base [1], which doesn't
actually add any usable utilities, and is just a dependency required
by other lsb utils.  I believe the intention was to add a dependency
on 'lsb', which adds a bunch of (unnecessary) stuff.

Chrome uses lsb_release (in base/linux_util), so a direct dependency
on 'lsb-release' is added.  The RPM packge doesn't have this problem
because it depends on 'lsb', which pulls in lsb-release.

[1] https://packages.ubuntu.com/xenial/lsb-base

BUG=724244
R=thestig@chromium.org,timbrown@chromium.org
==========

[Tom Anderson, 2017-05-23 18:01:35]

thestig@ ptal

[timbrown, 2017-05-23 21:25:27]

lgtm

[Lei Zhang, 2017-05-23 21:31:52]

Our original intentions was to depend on lsb, but seeing how it's mostly worked
out this is probably ok. Let me dig into the history really quickly and see how
we arrived here.

[Lei Zhang, 2017-05-23 21:34:40]

lgtm

Well, since we had an internal -> public repo move, some of the history is a bit
hard to track down. So let's let this be.

[Tom Anderson, 2017-05-23 21:38:52]

The CQ bit was checked by thomasanderson@chromium.org

[commit-bot: I haz the power, 2017-05-23 21:40:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 22:05:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495575532194000, "parent_rev":
"293c72b48fb321d33d6b06147807de9e4000924e", "commit_rev":
"1a4c9a8ed39d4b4ce648487981b1b53da4c3c0ea"}

[commit-bot: I haz the power, 2017-05-23 22:05:25]

Description was changed from

==========
Debian package: Add lsb-release to deps

The Debian package had a dependency on lsb-base [1], which doesn't
actually add any usable utilities, and is just a dependency required
by other lsb utils.  I believe the intention was to add a dependency
on 'lsb', which adds a bunch of (unnecessary) stuff.

Chrome uses lsb_release (in base/linux_util), so a direct dependency
on 'lsb-release' is added.  The RPM packge doesn't have this problem
because it depends on 'lsb', which pulls in lsb-release.

[1] https://packages.ubuntu.com/xenial/lsb-base

BUG=724244
R=thestig@chromium.org,timbrown@chromium.org
==========

to

==========
Debian package: Add lsb-release to deps

The Debian package had a dependency on lsb-base [1], which doesn't
actually add any usable utilities, and is just a dependency required
by other lsb utils.  I believe the intention was to add a dependency
on 'lsb', which adds a bunch of (unnecessary) stuff.

Chrome uses lsb_release (in base/linux_util), so a direct dependency
on 'lsb-release' is added.  The RPM packge doesn't have this problem
because it depends on 'lsb', which pulls in lsb-release.

[1] https://packages.ubuntu.com/xenial/lsb-base

BUG=724244
R=thestig@chromium.org,timbrown@chromium.org

Review-Url: https://codereview.chromium.org/2897033004
Cr-Commit-Position: refs/heads/master@{#474078}
Committed:
https://chromium.googlesource.com/chromium/src/+/1a4c9a8ed39d4b4ce648487981b1...
==========

[commit-bot: I haz the power, 2017-05-23 22:05:26]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1a4c9a8ed39d4b4ce648487981b1...