Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 2897013002: Remove deprecated-declarations warnings. (Closed)

Created:
3 years, 7 months ago by lpromero
Modified:
3 years, 7 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, ios-reviews_chromium.org, Nico
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -19 lines) Patch
M ios/third_party/gcdwebserver/BUILD.gn View 2 chunks +1 line, -13 lines 1 comment Download
M ios/third_party/material_components_ios/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
lpromero
3 years, 7 months ago (2017-05-23 11:29:32 UTC) #1
sdefresne
lgtm https://codereview.chromium.org/2897013002/diff/1/ios/third_party/gcdwebserver/BUILD.gn File ios/third_party/gcdwebserver/BUILD.gn (left): https://codereview.chromium.org/2897013002/diff/1/ios/third_party/gcdwebserver/BUILD.gn#oldcode23 ios/third_party/gcdwebserver/BUILD.gn:23: # TODO(crbug.com/569158): Suppresses warnings that are treated as ...
3 years, 7 months ago (2017-05-23 13:13:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897013002/1
3 years, 7 months ago (2017-05-23 13:13:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a4581b46788c22124a6fd749e793c3015aaa3891
3 years, 7 months ago (2017-05-23 13:17:38 UTC) #12
Nico
3 years, 7 months ago (2017-05-23 14:29:42 UTC) #13
Message was sent while issue was closed.
Thanks!

On Tue, May 23, 2017 at 9:17 AM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Committed patchset #1 (id:1) as
> https://chromium.googlesource.com/chromium/src/+/
> a4581b46788c22124a6fd749e793c3015aaa3891
>
> https://codereview.chromium.org/2897013002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698