Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1653)

Issue 2897003002: Remove SetWrapperReferenceTo from idl_definitions (Closed)

Created:
3 years, 7 months ago by riju_
Modified:
3 years, 7 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SetWrapperReferenceTo from idl_definitions crrev.com/2676663006 removed SetWrapperReferenceTo. Removing it from the idl definitions as it is not used anywhere. BUG= Review-Url: https://codereview.chromium.org/2897003002 Cr-Commit-Position: refs/heads/master@{#473851} Committed: https://chromium.googlesource.com/chromium/src/+/5b61fb7515b28b6c227d4fd379968c1faa06ed8d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M third_party/WebKit/Source/bindings/scripts/idl_definitions.py View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
riju_
haraken@ : PTAL.
3 years, 7 months ago (2017-05-23 10:16:13 UTC) #6
Yuki
LGTM.
3 years, 7 months ago (2017-05-23 10:25:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897003002/1
3 years, 7 months ago (2017-05-23 10:32:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5b61fb7515b28b6c227d4fd379968c1faa06ed8d
3 years, 7 months ago (2017-05-23 10:41:15 UTC) #13
haraken
3 years, 7 months ago (2017-05-23 10:48:41 UTC) #14
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698