Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2896953002: Fix the parsing error in tools/metrics/histograms/histograms.xml (Closed)

Created:
3 years, 7 months ago by chengx
Modified:
3 years, 7 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the parsing error in tools/metrics/histograms/histograms.xml tools\metrics\histograms/pretty_print.py fails to parse tools/metrics/histograms/histograms.xml due to 1) ERROR:root:Unknown enum DnsProbe.obsoleteProbeResult 2) ERROR:root:Unrecognized tag "obselete" The failure of running pretty_print.py blocks uploading any CL containing histograms.xml! This CL removes DnsProbe.obsoleteProbeResult in three obsolete histograms, and fixes "obselete" to "obsolete". Running tools\metrics\histograms/pretty_print.py formats a few other lines of code. This CL keeps this change. BUG=725310 Review-Url: https://codereview.chromium.org/2896953002 Cr-Commit-Position: refs/heads/master@{#473900} Committed: https://chromium.googlesource.com/chromium/src/+/f9f94c9184a56421696578030d7621823b17a39a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -17 lines) Patch
M tools/metrics/histograms/histograms.xml View 7 chunks +11 lines, -17 lines 0 comments Download

Messages

Total messages: 23 (19 generated)
chengx
PTAL, this is kind of urgent as it blocks any CLs containing histograms.xml!
3 years, 7 months ago (2017-05-23 00:42:42 UTC) #6
Alexei Svitkine (slow)
lgtm
3 years, 7 months ago (2017-05-23 15:06:04 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896953002/40001
3 years, 7 months ago (2017-05-23 15:06:42 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 15:12:38 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f9f94c9184a56421696578030d76...

Powered by Google App Engine
This is Rietveld 408576698