|
|
DescriptionFix the parsing error in tools/metrics/histograms/histograms.xml
tools\metrics\histograms/pretty_print.py fails to parse
tools/metrics/histograms/histograms.xml due to
1) ERROR:root:Unknown enum DnsProbe.obsoleteProbeResult
2) ERROR:root:Unrecognized tag "obselete"
The failure of running pretty_print.py blocks uploading any CL
containing histograms.xml!
This CL removes DnsProbe.obsoleteProbeResult in three obsolete
histograms, and fixes "obselete" to "obsolete".
Running tools\metrics\histograms/pretty_print.py formats a few other
lines of code. This CL keeps this change.
BUG=725310
Review-Url: https://codereview.chromium.org/2896953002
Cr-Commit-Position: refs/heads/master@{#473900}
Committed: https://chromium.googlesource.com/chromium/src/+/f9f94c9184a56421696578030d7621823b17a39a
Patch Set 1 #
Messages
Total messages: 23 (19 generated)
Description was changed from ========== Fix broken histograms Format code Format obsolete tag in histograms.xml BUG= ========== to ========== Fix tools/metrics/histograms/histograms.xml BUG= ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Description was changed from ========== Fix tools/metrics/histograms/histograms.xml BUG= ========== to ========== Fix tools/metrics/histograms/histograms.xml "git cl upload" doesn't allow to upload histograms.xml due to 1) ERROR:root:Unknown enum DnsProbe.obsoleteProbeResult 2) ERROR:root:Unrecognized tag "obselete" This CL removes DnsProbe.obsoleteProbeResult in three obsolete histograms, and fix "obselete" to "obsolete". Running tools\metrics\histograms/pretty_print.py leads to a few other lines of code formatted. This CL keeps them. BUG= ==========
chengx@chromium.org changed reviewers: + isherman@chromium.org
PTAL, this is kind of urgent as it blocks any CLs containing histograms.xml!
The CQ bit was checked by chengx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix tools/metrics/histograms/histograms.xml "git cl upload" doesn't allow to upload histograms.xml due to 1) ERROR:root:Unknown enum DnsProbe.obsoleteProbeResult 2) ERROR:root:Unrecognized tag "obselete" This CL removes DnsProbe.obsoleteProbeResult in three obsolete histograms, and fix "obselete" to "obsolete". Running tools\metrics\histograms/pretty_print.py leads to a few other lines of code formatted. This CL keeps them. BUG= ========== to ========== Fix the parsing error in tools/metrics/histograms/histograms.xml tools\metrics\histograms/pretty_print.py cannot parse tools/metrics/histograms/histograms.xml due to 1) ERROR:root:Unknown enum DnsProbe.obsoleteProbeResult 2) ERROR:root:Unrecognized tag "obselete" The failure of running pretty_print.py blocks uploading any CL containing histograms.xml! This CL removes DnsProbe.obsoleteProbeResult in three obsolete histograms, and fix "obselete" to "obsolete". Running tools\metrics\histograms/pretty_print.py leads to a few other lines of code formatted. This CL keeps them. BUG=725310 ==========
Description was changed from ========== Fix the parsing error in tools/metrics/histograms/histograms.xml tools\metrics\histograms/pretty_print.py cannot parse tools/metrics/histograms/histograms.xml due to 1) ERROR:root:Unknown enum DnsProbe.obsoleteProbeResult 2) ERROR:root:Unrecognized tag "obselete" The failure of running pretty_print.py blocks uploading any CL containing histograms.xml! This CL removes DnsProbe.obsoleteProbeResult in three obsolete histograms, and fix "obselete" to "obsolete". Running tools\metrics\histograms/pretty_print.py leads to a few other lines of code formatted. This CL keeps them. BUG=725310 ========== to ========== Fix the parsing error in tools/metrics/histograms/histograms.xml tools\metrics\histograms/pretty_print.py cannot parse tools/metrics/histograms/histograms.xml due to 1) ERROR:root:Unknown enum DnsProbe.obsoleteProbeResult 2) ERROR:root:Unrecognized tag "obselete" The failure of running pretty_print.py blocks uploading any CL containing histograms.xml! This CL removes DnsProbe.obsoleteProbeResult in three obsolete histograms, and fix "obselete" to "obsolete". Running tools\metrics\histograms/pretty_print.py leads to a few other lines of code formatted. This CL keeps them. BUG=725310 ==========
Description was changed from ========== Fix the parsing error in tools/metrics/histograms/histograms.xml tools\metrics\histograms/pretty_print.py cannot parse tools/metrics/histograms/histograms.xml due to 1) ERROR:root:Unknown enum DnsProbe.obsoleteProbeResult 2) ERROR:root:Unrecognized tag "obselete" The failure of running pretty_print.py blocks uploading any CL containing histograms.xml! This CL removes DnsProbe.obsoleteProbeResult in three obsolete histograms, and fix "obselete" to "obsolete". Running tools\metrics\histograms/pretty_print.py leads to a few other lines of code formatted. This CL keeps them. BUG=725310 ========== to ========== Fix the parsing error in tools/metrics/histograms/histograms.xml tools\metrics\histograms/pretty_print.py cannot parse tools/metrics/histograms/histograms.xml due to 1) ERROR:root:Unknown enum DnsProbe.obsoleteProbeResult 2) ERROR:root:Unrecognized tag "obselete" The failure of running pretty_print.py blocks uploading any CL containing histograms.xml! This CL removes DnsProbe.obsoleteProbeResult in three obsolete histograms, and fix "obselete" to "obsolete". Running tools\metrics\histograms/pretty_print.py leads to a few other lines of code formatted. This CL keeps them. BUG=725310 ==========
Description was changed from ========== Fix the parsing error in tools/metrics/histograms/histograms.xml tools\metrics\histograms/pretty_print.py cannot parse tools/metrics/histograms/histograms.xml due to 1) ERROR:root:Unknown enum DnsProbe.obsoleteProbeResult 2) ERROR:root:Unrecognized tag "obselete" The failure of running pretty_print.py blocks uploading any CL containing histograms.xml! This CL removes DnsProbe.obsoleteProbeResult in three obsolete histograms, and fix "obselete" to "obsolete". Running tools\metrics\histograms/pretty_print.py leads to a few other lines of code formatted. This CL keeps them. BUG=725310 ========== to ========== Fix the parsing error in tools/metrics/histograms/histograms.xml tools\metrics\histograms/pretty_print.py fails to parse tools/metrics/histograms/histograms.xml due to 1) ERROR:root:Unknown enum DnsProbe.obsoleteProbeResult 2) ERROR:root:Unrecognized tag "obselete" The failure of running pretty_print.py blocks uploading any CL containing histograms.xml! This CL removes DnsProbe.obsoleteProbeResult in three obsolete histograms, and fix "obselete" to "obsolete". Running tools\metrics\histograms/pretty_print.py leads to a few other lines of code formatted. This CL keeps them. BUG=725310 ==========
Description was changed from ========== Fix the parsing error in tools/metrics/histograms/histograms.xml tools\metrics\histograms/pretty_print.py fails to parse tools/metrics/histograms/histograms.xml due to 1) ERROR:root:Unknown enum DnsProbe.obsoleteProbeResult 2) ERROR:root:Unrecognized tag "obselete" The failure of running pretty_print.py blocks uploading any CL containing histograms.xml! This CL removes DnsProbe.obsoleteProbeResult in three obsolete histograms, and fix "obselete" to "obsolete". Running tools\metrics\histograms/pretty_print.py leads to a few other lines of code formatted. This CL keeps them. BUG=725310 ========== to ========== Fix the parsing error in tools/metrics/histograms/histograms.xml tools\metrics\histograms/pretty_print.py fails to parse tools/metrics/histograms/histograms.xml due to 1) ERROR:root:Unknown enum DnsProbe.obsoleteProbeResult 2) ERROR:root:Unrecognized tag "obselete" The failure of running pretty_print.py blocks uploading any CL containing histograms.xml! This CL removes DnsProbe.obsoleteProbeResult in three obsolete histograms, and fix "obselete" to "obsolete". Running tools\metrics\histograms/pretty_print.py formats a few other lines of code. This CL keeps this change. BUG=725310 ==========
Description was changed from ========== Fix the parsing error in tools/metrics/histograms/histograms.xml tools\metrics\histograms/pretty_print.py fails to parse tools/metrics/histograms/histograms.xml due to 1) ERROR:root:Unknown enum DnsProbe.obsoleteProbeResult 2) ERROR:root:Unrecognized tag "obselete" The failure of running pretty_print.py blocks uploading any CL containing histograms.xml! This CL removes DnsProbe.obsoleteProbeResult in three obsolete histograms, and fix "obselete" to "obsolete". Running tools\metrics\histograms/pretty_print.py formats a few other lines of code. This CL keeps this change. BUG=725310 ========== to ========== Fix the parsing error in tools/metrics/histograms/histograms.xml tools\metrics\histograms/pretty_print.py fails to parse tools/metrics/histograms/histograms.xml due to 1) ERROR:root:Unknown enum DnsProbe.obsoleteProbeResult 2) ERROR:root:Unrecognized tag "obselete" The failure of running pretty_print.py blocks uploading any CL containing histograms.xml! This CL removes DnsProbe.obsoleteProbeResult in three obsolete histograms, and fixes "obselete" to "obsolete". Running tools\metrics\histograms/pretty_print.py formats a few other lines of code. This CL keeps this change. BUG=725310 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
asvitkine@chromium.org changed reviewers: + asvitkine@chromium.org
The CQ bit was checked by asvitkine@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495551963651240, "parent_rev": "07395f80fb332d0712ccf37404c23ce4356fa416", "commit_rev": "f9f94c9184a56421696578030d7621823b17a39a"}
Message was sent while issue was closed.
Description was changed from ========== Fix the parsing error in tools/metrics/histograms/histograms.xml tools\metrics\histograms/pretty_print.py fails to parse tools/metrics/histograms/histograms.xml due to 1) ERROR:root:Unknown enum DnsProbe.obsoleteProbeResult 2) ERROR:root:Unrecognized tag "obselete" The failure of running pretty_print.py blocks uploading any CL containing histograms.xml! This CL removes DnsProbe.obsoleteProbeResult in three obsolete histograms, and fixes "obselete" to "obsolete". Running tools\metrics\histograms/pretty_print.py formats a few other lines of code. This CL keeps this change. BUG=725310 ========== to ========== Fix the parsing error in tools/metrics/histograms/histograms.xml tools\metrics\histograms/pretty_print.py fails to parse tools/metrics/histograms/histograms.xml due to 1) ERROR:root:Unknown enum DnsProbe.obsoleteProbeResult 2) ERROR:root:Unrecognized tag "obselete" The failure of running pretty_print.py blocks uploading any CL containing histograms.xml! This CL removes DnsProbe.obsoleteProbeResult in three obsolete histograms, and fixes "obselete" to "obsolete". Running tools\metrics\histograms/pretty_print.py formats a few other lines of code. This CL keeps this change. BUG=725310 Review-Url: https://codereview.chromium.org/2896953002 Cr-Commit-Position: refs/heads/master@{#473900} Committed: https://chromium.googlesource.com/chromium/src/+/f9f94c9184a56421696578030d76... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as https://chromium.googlesource.com/chromium/src/+/f9f94c9184a56421696578030d76... |