Reland [Mojo Video Capture] Hook up video capture service behind a feature flag

Reland [Mojo Video Capture] Hook up video capture service behind a feature flag

Link to original CL: https://codereview.chromium.org/2867213004/

PatchSet 1 is the state as reviewed previously.
PatchSet 2 fixes the reasons for the revert.

Description of issues
---------------------
1.) Webkit Android bots for blink_heap_unittests and webkit_unit_tests fail with
OSError: [Errno 2] No such file or directory: '/b/c/b/WebKit_Android__Nexus4_/src/out/Release/gen/services/video_capture/manifest.json'
2.) MSan tests fail when running VideoCaptureBrowserTest.ReceiveFramesFromFakeCaptureDevice/22

Description of fixes
--------------------
For 1.: Removed an unnecessary data_dep on on the service manifest. Even though
  unclear why the particular tests would want to use the manifest file and why 
  it was not copied, this is likely to fix the issue.
For 2.: It appears that this is an existing issue that was triggered by the 
  new test cases added in this CL. I am disabling these test cases for now, and 
  added https://crbug.com/725271 to track the issue.


Original CL description
-----------------------

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL25.

After this CL, the video capture service can be enabled by starting Chrome with
command-line flag --enable-features=MojoVideoCapture.

Changes in this CL:
* Add a base::Feature kMojoVideoCapture to allow switching the service on and
  off.
* Add a class VideoCaptureProviderSwitcher that can route device capture
  requests to the service's VideoCaptureProvider while routing screen capture
  requests to the InProcessVideoCaptureProvider.
* Hook up the VideoCaptureProviderSwitcher in the factory code in
  MediaStreamManager.
* Register video capture service in the service manager context for the Browser
  process.
* Remove build flag "enable_mojo_video_capture", since we want the service to
  be testable in all builds.
* Forward switches for using fake video capture devices to utility processes.
* Add test cases for exercising the service to VideoCaptureBrowserTest.

BUG=584797
TEST=
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"
TBR=mcasas@chromium.org,rockot@chromium.org,piman@chromium.org,tsepez@chromium.org

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Review-Url: https://codereview.chromium.org/2896913002
Cr-Commit-Position: refs/heads/master@{#473902}
Committed: https://chromium.googlesource.com/chromium/src/+/70b40e5124b29181bb42c870c3bf7498e6075022

[chfremer, 2017-05-22 23:24:35]

Description was changed from

==========
Reland [Mojo Video Capture] Hook up video capture service behind a feature flag

Link to original CL: https://codereview.chromium.org/2867213004/

PatchSet 1 is the state as reviewed previously.
PatchSet 2 fixes the reasons for the revert.

Description of fixes
--------------------
TODO



Original CL description
-----------------------

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL25.

After this CL, the video capture service can be enabled by starting Chrome with
command-line flag --enable-features=MojoVideoCapture.

Changes in this CL:
* Add a base::Feature kMojoVideoCapture to allow switching the service on and
  off.
* Add a class VideoCaptureProviderSwitcher that can route device capture
  requests to the service's VideoCaptureProvider while routing screen capture
  requests to the InProcessVideoCaptureProvider.
* Hook up the VideoCaptureProviderSwitcher in the factory code in
  MediaStreamManager.
* Register video capture service in the service manager context for the Browser
  process.
* Remove build flag "enable_mojo_video_capture", since we want the service to
  be testable in all builds.
* Forward switches for using fake video capture devices to utility processes.
* Add test cases for exercising the service to VideoCaptureBrowserTest.

BUG=584797
TEST=
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

to

==========
Reland [Mojo Video Capture] Hook up video capture service behind a feature flag

Link to original CL: https://codereview.chromium.org/2867213004/

PatchSet 1 is the state as reviewed previously.
PatchSet 2 fixes the reasons for the revert.

Description of issues
---------------------
1.) Webkit Android bots for blink_heap_unittests and webkit_unit_tests fail with
OSError: [Errno 2] No such file or directory:
'/b/c/b/WebKit_Android__Nexus4_/src/out/Release/gen/services/video_capture/manifest.json'
2.) MSan tests fail when running
VideoCaptureBrowserTest.ReceiveFramesFromFakeCaptureDevice/22

Description of fixes
--------------------
For 1.: Removed an unnecessary data_dep on on the service manifest. Even though
  unclear why the particular tests would want to use the manifest file and why 
  it was not copied, this is likely to fix the issue.
For 2.: It appears that this is an existing issue that was triggered by the 
  new test cases added in this CL. I am disabling these test cases for now, and 
  added https://crbug.com/725271 to track the issue.


Original CL description
-----------------------

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL25.

After this CL, the video capture service can be enabled by starting Chrome with
command-line flag --enable-features=MojoVideoCapture.

Changes in this CL:
* Add a base::Feature kMojoVideoCapture to allow switching the service on and
  off.
* Add a class VideoCaptureProviderSwitcher that can route device capture
  requests to the service's VideoCaptureProvider while routing screen capture
  requests to the InProcessVideoCaptureProvider.
* Hook up the VideoCaptureProviderSwitcher in the factory code in
  MediaStreamManager.
* Register video capture service in the service manager context for the Browser
  process.
* Remove build flag "enable_mojo_video_capture", since we want the service to
  be testable in all builds.
* Forward switches for using fake video capture devices to utility processes.
* Add test cases for exercising the service to VideoCaptureBrowserTest.

BUG=584797
TEST=
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

[chfremer, 2017-05-22 23:24:42]

The CQ bit was checked by chfremer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 23:25:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chfremer, 2017-05-22 23:26:39]

Description was changed from

==========
Reland [Mojo Video Capture] Hook up video capture service behind a feature flag

Link to original CL: https://codereview.chromium.org/2867213004/

PatchSet 1 is the state as reviewed previously.
PatchSet 2 fixes the reasons for the revert.

Description of issues
---------------------
1.) Webkit Android bots for blink_heap_unittests and webkit_unit_tests fail with
OSError: [Errno 2] No such file or directory:
'/b/c/b/WebKit_Android__Nexus4_/src/out/Release/gen/services/video_capture/manifest.json'
2.) MSan tests fail when running
VideoCaptureBrowserTest.ReceiveFramesFromFakeCaptureDevice/22

Description of fixes
--------------------
For 1.: Removed an unnecessary data_dep on on the service manifest. Even though
  unclear why the particular tests would want to use the manifest file and why 
  it was not copied, this is likely to fix the issue.
For 2.: It appears that this is an existing issue that was triggered by the 
  new test cases added in this CL. I am disabling these test cases for now, and 
  added https://crbug.com/725271 to track the issue.


Original CL description
-----------------------

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL25.

After this CL, the video capture service can be enabled by starting Chrome with
command-line flag --enable-features=MojoVideoCapture.

Changes in this CL:
* Add a base::Feature kMojoVideoCapture to allow switching the service on and
  off.
* Add a class VideoCaptureProviderSwitcher that can route device capture
  requests to the service's VideoCaptureProvider while routing screen capture
  requests to the InProcessVideoCaptureProvider.
* Hook up the VideoCaptureProviderSwitcher in the factory code in
  MediaStreamManager.
* Register video capture service in the service manager context for the Browser
  process.
* Remove build flag "enable_mojo_video_capture", since we want the service to
  be testable in all builds.
* Forward switches for using fake video capture devices to utility processes.
* Add test cases for exercising the service to VideoCaptureBrowserTest.

BUG=584797
TEST=
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

to

==========
Reland [Mojo Video Capture] Hook up video capture service behind a feature flag

Link to original CL: https://codereview.chromium.org/2867213004/

PatchSet 1 is the state as reviewed previously.
PatchSet 2 fixes the reasons for the revert.

Description of issues
---------------------
1.) Webkit Android bots for blink_heap_unittests and webkit_unit_tests fail with
OSError: [Errno 2] No such file or directory:
'/b/c/b/WebKit_Android__Nexus4_/src/out/Release/gen/services/video_capture/manifest.json'
2.) MSan tests fail when running
VideoCaptureBrowserTest.ReceiveFramesFromFakeCaptureDevice/22

Description of fixes
--------------------
For 1.: Removed an unnecessary data_dep on on the service manifest. Even though
  unclear why the particular tests would want to use the manifest file and why 
  it was not copied, this is likely to fix the issue.
For 2.: It appears that this is an existing issue that was triggered by the 
  new test cases added in this CL. I am disabling these test cases for now, and 
  added https://crbug.com/725271 to track the issue.


Original CL description
-----------------------

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL25.

After this CL, the video capture service can be enabled by starting Chrome with
command-line flag --enable-features=MojoVideoCapture.

Changes in this CL:
* Add a base::Feature kMojoVideoCapture to allow switching the service on and
  off.
* Add a class VideoCaptureProviderSwitcher that can route device capture
  requests to the service's VideoCaptureProvider while routing screen capture
  requests to the InProcessVideoCaptureProvider.
* Hook up the VideoCaptureProviderSwitcher in the factory code in
  MediaStreamManager.
* Register video capture service in the service manager context for the Browser
  process.
* Remove build flag "enable_mojo_video_capture", since we want the service to
  be testable in all builds.
* Forward switches for using fake video capture devices to utility processes.
* Add test cases for exercising the service to VideoCaptureBrowserTest.

BUG=584797
TEST=
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"
TBR=mcasas@chromium.org,rockot@chromium.org,piman@chromium.org,tsepez@chromiu...

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

[chfremer, 2017-05-22 23:28:25]

chfremer@chromium.org changed reviewers:
+ mcasas@chromium.org, piman@chromium.org, rockot@chromium.org,
tsepez@chromium.org

[chfremer, 2017-05-22 23:28:26]

TBR

[commit-bot: I haz the power, 2017-05-23 01:47:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 01:47:17]

Dry run: This issue passed the CQ dry run.

[chfremer, 2017-05-23 15:07:55]

The CQ bit was checked by chfremer@chromium.org

[commit-bot: I haz the power, 2017-05-23 15:08:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 15:14:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495552075579050,
"parent_rev": "4bf88baf6b31bb55da7bf98606818b841979354a", "commit_rev":
"70b40e5124b29181bb42c870c3bf7498e6075022"}

[commit-bot: I haz the power, 2017-05-23 15:14:17]

Description was changed from

==========
Reland [Mojo Video Capture] Hook up video capture service behind a feature flag

Link to original CL: https://codereview.chromium.org/2867213004/

PatchSet 1 is the state as reviewed previously.
PatchSet 2 fixes the reasons for the revert.

Description of issues
---------------------
1.) Webkit Android bots for blink_heap_unittests and webkit_unit_tests fail with
OSError: [Errno 2] No such file or directory:
'/b/c/b/WebKit_Android__Nexus4_/src/out/Release/gen/services/video_capture/manifest.json'
2.) MSan tests fail when running
VideoCaptureBrowserTest.ReceiveFramesFromFakeCaptureDevice/22

Description of fixes
--------------------
For 1.: Removed an unnecessary data_dep on on the service manifest. Even though
  unclear why the particular tests would want to use the manifest file and why 
  it was not copied, this is likely to fix the issue.
For 2.: It appears that this is an existing issue that was triggered by the 
  new test cases added in this CL. I am disabling these test cases for now, and 
  added https://crbug.com/725271 to track the issue.


Original CL description
-----------------------

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL25.

After this CL, the video capture service can be enabled by starting Chrome with
command-line flag --enable-features=MojoVideoCapture.

Changes in this CL:
* Add a base::Feature kMojoVideoCapture to allow switching the service on and
  off.
* Add a class VideoCaptureProviderSwitcher that can route device capture
  requests to the service's VideoCaptureProvider while routing screen capture
  requests to the InProcessVideoCaptureProvider.
* Hook up the VideoCaptureProviderSwitcher in the factory code in
  MediaStreamManager.
* Register video capture service in the service manager context for the Browser
  process.
* Remove build flag "enable_mojo_video_capture", since we want the service to
  be testable in all builds.
* Forward switches for using fake video capture devices to utility processes.
* Add test cases for exercising the service to VideoCaptureBrowserTest.

BUG=584797
TEST=
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"
TBR=mcasas@chromium.org,rockot@chromium.org,piman@chromium.org,tsepez@chromiu...

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

to

==========
Reland [Mojo Video Capture] Hook up video capture service behind a feature flag

Link to original CL: https://codereview.chromium.org/2867213004/

PatchSet 1 is the state as reviewed previously.
PatchSet 2 fixes the reasons for the revert.

Description of issues
---------------------
1.) Webkit Android bots for blink_heap_unittests and webkit_unit_tests fail with
OSError: [Errno 2] No such file or directory:
'/b/c/b/WebKit_Android__Nexus4_/src/out/Release/gen/services/video_capture/manifest.json'
2.) MSan tests fail when running
VideoCaptureBrowserTest.ReceiveFramesFromFakeCaptureDevice/22

Description of fixes
--------------------
For 1.: Removed an unnecessary data_dep on on the service manifest. Even though
  unclear why the particular tests would want to use the manifest file and why 
  it was not copied, this is likely to fix the issue.
For 2.: It appears that this is an existing issue that was triggered by the 
  new test cases added in this CL. I am disabling these test cases for now, and 
  added https://crbug.com/725271 to track the issue.


Original CL description
-----------------------

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL25.

After this CL, the video capture service can be enabled by starting Chrome with
command-line flag --enable-features=MojoVideoCapture.

Changes in this CL:
* Add a base::Feature kMojoVideoCapture to allow switching the service on and
  off.
* Add a class VideoCaptureProviderSwitcher that can route device capture
  requests to the service's VideoCaptureProvider while routing screen capture
  requests to the InProcessVideoCaptureProvider.
* Hook up the VideoCaptureProviderSwitcher in the factory code in
  MediaStreamManager.
* Register video capture service in the service manager context for the Browser
  process.
* Remove build flag "enable_mojo_video_capture", since we want the service to
  be testable in all builds.
* Forward switches for using fake video capture devices to utility processes.
* Add test cases for exercising the service to VideoCaptureBrowserTest.

BUG=584797
TEST=
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"
TBR=mcasas@chromium.org,rockot@chromium.org,piman@chromium.org,tsepez@chromiu...

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...

Review-Url: https://codereview.chromium.org/2896913002
Cr-Commit-Position: refs/heads/master@{#473902}
Committed:
https://chromium.googlesource.com/chromium/src/+/70b40e5124b29181bb42c870c3bf...
==========

[commit-bot: I haz the power, 2017-05-23 15:14:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/70b40e5124b29181bb42c870c3bf...