Unify toolbar, NTP, and tab switcher text styles

Unify toolbar, NTP, and tab switcher text styles

+ Change omnibox URL path text to 38% black
+ Change omnibox status 'Offline' text to 54% black
+ Change omnibox 'Search or type URL' text to 38% black
+ Change omnibox selected and suggestions to 87% black
+ Move color constants in SuggestionView and AnswerTextBuilder to color.xml
+ Change NTP 'learn more' text to regular font
+ Change Frequently visited tiles to 54% black
+ Change tab switcher titles to 87% black

BUG=723042, 723047
R=twellington@chromium.org

Review-Url: https://codereview.chromium.org/2896883003
Cr-Commit-Position: refs/heads/master@{#475602}
Committed: https://chromium.googlesource.com/chromium/src/+/e2c96f726dffb1ba319a3ed7d4da8aa0c1156fb2

[huayinz, 2017-05-22 22:56:16]

Patchset #1 (id:1) has been deleted

[huayinz, 2017-05-22 22:56:23]

Patchset #1 (id:20001) has been deleted

[huayinz, 2017-05-22 22:57:54]

Hi Theresa,

Could you take a look?

Thanks,
Becky

[Theresa, 2017-05-23 15:27:36]

Thank you for pulling all of those Java constants into colors.xml! That makes it
much easier to audit/track what colors we're using in Chrome. I have a few
questions on styles, some of which I asked Hannah in in the text style guide.

https://codereview.chromium.org/2896883003/diff/40001/chrome/android/java/res...
File chrome/android/java/res/values/colors.xml (right):

https://codereview.chromium.org/2896883003/diff/40001/chrome/android/java/res...
chrome/android/java/res/values/colors.xml:81: <color
name="suggestion_url">#5595fe</color>
This color looks like it's marked to be deprecated in Hannah's text style guide.
I think this falls under these two rules in the guide:

Styles to be deprecated:
...
Reg 14 - Blue Omnibox Dropdown Url - #5595FE
Bold 14 - Blue Omnibox Dropdown Bold - #5595FE
...

Updated text styles and colors:
Change Omnibox selected (entered text) and suggestions to Material Primary (87%)

https://codereview.chromium.org/2896883003/diff/40001/chrome/android/java/res...
chrome/android/java/res/values/colors.xml:83: <color
name="answers_description_text_positive">@color/google_green_700</color>
I think the positive and negative answers description also fall under deprecated
styles:
Reg 17 - Omnibox Insecure - Google Red 700 - #C53929
Reg 17 - Omnibox Protocol - Google Green 700 - #0B8043


I also don't see #8a8a8a on the text style guide at all. It would be good to
check in with Hannah on here expectation for answers_answer_text.

https://codereview.chromium.org/2896883003/diff/40001/chrome/android/java/res...
chrome/android/java/res/values/colors.xml:105: <color
name="compositor_tab_title_bar_text">@color/black_alpha_87</color>
This falls under "Tab switcher titles to Material Gray 900 (87%)", correct?

[Theresa, 2017-05-24 20:23:41]

I think it's okay to land this after making the one suggested change to the
suggestions_url color. We can update the answers positive/negative/text after UX
settles on what colors they should be.

[huayinz, 2017-05-24 21:31:58]

On 2017/05/24 20:23:41, Theresa (OOO) wrote:
> I think it's okay to land this after making the one suggested change to the
> suggestions_url color. We can update the answers positive/negative/text after
UX
> settles on what colors they should be.

Sure, thanks for your advice.

[huayinz, 2017-05-24 21:32:24]

https://codereview.chromium.org/2896883003/diff/40001/chrome/android/java/res...
File chrome/android/java/res/values/colors.xml (right):

https://codereview.chromium.org/2896883003/diff/40001/chrome/android/java/res...
chrome/android/java/res/values/colors.xml:81: <color
name="suggestion_url">#5595fe</color>
On 2017/05/23 15:27:36, Theresa wrote:
> This color looks like it's marked to be deprecated in Hannah's text style
guide.
> I think this falls under these two rules in the guide:
> 
> Styles to be deprecated:
> ...
> Reg 14 - Blue Omnibox Dropdown Url - #5595FE
> Bold 14 - Blue Omnibox Dropdown Bold - #5595FE
> ...
> 
> Updated text styles and colors:
> Change Omnibox selected (entered text) and suggestions to Material Primary
(87%)

I found there is another bug 723040 tracking the color change for blue link
text. I'll go ahead and change this.

https://codereview.chromium.org/2896883003/diff/40001/chrome/android/java/res...
chrome/android/java/res/values/colors.xml:105: <color
name="compositor_tab_title_bar_text">@color/black_alpha_87</color>
On 2017/05/23 15:27:36, Theresa wrote:
> This falls under "Tab switcher titles to Material Gray 900 (87%)", correct?

Yes, this color is used for the title of each page in the tab switcher.

[Theresa, 2017-05-30 16:26:29]

lgtm

[huayinz, 2017-05-30 16:47:52]

huayinz@chromium.org changed reviewers:
+ tedchoc@chromium.org

[huayinz, 2017-05-30 16:47:52]

tedchoc@chromium.org: Hi Ted, could you take a look? 

Thanks,
Becky

[Ted C, 2017-05-30 16:55:38]

lgtm

[huayinz, 2017-05-30 17:27:30]

The CQ bit was checked by huayinz@chromium.org

[commit-bot: I haz the power, 2017-05-30 17:28:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 18:21:54]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496165250046940,
"parent_rev": "505078044cfca8e67070b4daed6e6157d7641774", "commit_rev":
"e2c96f726dffb1ba319a3ed7d4da8aa0c1156fb2"}

[commit-bot: I haz the power, 2017-05-30 18:22:05]

Description was changed from

==========
Unify toolbar, NTP, and tab switcher text styles

+ Change omnibox URL path text to 38% black
+ Change omnibox status 'Offline' text to 54% black
+ Change omnibox 'Search or type URL' text to 38% black
+ Change omnibox selected and suggestions to 87% black
+ Move color constants in SuggestionView and AnswerTextBuilder to color.xml
+ Change NTP 'learn more' text to regular font
+ Change Frequently visited tiles to 54% black
+ Change tab switcher titles to 87% black

BUG=723042,723047
R=twellington@chromium.org
==========

to

==========
Unify toolbar, NTP, and tab switcher text styles

+ Change omnibox URL path text to 38% black
+ Change omnibox status 'Offline' text to 54% black
+ Change omnibox 'Search or type URL' text to 38% black
+ Change omnibox selected and suggestions to 87% black
+ Move color constants in SuggestionView and AnswerTextBuilder to color.xml
+ Change NTP 'learn more' text to regular font
+ Change Frequently visited tiles to 54% black
+ Change tab switcher titles to 87% black

BUG=723042,723047
R=twellington@chromium.org

Review-Url: https://codereview.chromium.org/2896883003
Cr-Commit-Position: refs/heads/master@{#475602}
Committed:
https://chromium.googlesource.com/chromium/src/+/e2c96f726dffb1ba319a3ed7d4da...
==========

[commit-bot: I haz the power, 2017-05-30 18:22:08]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e2c96f726dffb1ba319a3ed7d4da...