Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2896883002: Fix for HTTP2 request hanging bug. (Closed)

Created:
3 years, 7 months ago by mmenke
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Fix for HTTP2 request hanging bug. If, when a socket request completed asynchronously, the next socket request in the queue failed synchronously, ClientSocketPoolBase wouldn't continue to try to service other socket requests in the queue. As a result, the socket pools could end up with pending connect requests and free socket slots, but no ConnectJobs would be made to service them, if this happened 6 times in a row to a socket group. This was a relatively obscure issue, until H2 started depending on this path for sharing sessions when different domains map to the same IP. BUG=723748 Review-Url: https://codereview.chromium.org/2888623011 Cr-Original-Commit-Position: refs/heads/master@{#472952} Review-Url: https://codereview.chromium.org/2896883002 . Cr-Commit-Position: refs/branch-heads/3071@{#654} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/ef63c09a56bf127df9990b3e7412f543b4733b0b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -27 lines) Patch
M net/socket/client_socket_pool_base.cc View 1 chunk +26 lines, -27 lines 0 comments Download
M net/socket/client_socket_pool_base_unittest.cc View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mmenke
3 years, 7 months ago (2017-05-22 16:27:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ef63c09a56bf127df9990b3e7412f543b4733b0b.

Powered by Google App Engine
This is Rietveld 408576698