Chromium Code Reviews
DescriptionFix for HTTP2 request hanging bug.
If, when a socket request completed asynchronously, the next
socket request in the queue failed synchronously,
ClientSocketPoolBase wouldn't continue to try to service other
socket requests in the queue.
As a result, the socket pools could end up with pending connect
requests and free socket slots, but no ConnectJobs would be made
to service them, if this happened 6 times in a row to a socket
group.
This was a relatively obscure issue, until H2 started depending
on this path for sharing sessions when different domains map to
the same IP.
BUG=723748
Review-Url: https://codereview.chromium.org/2888623011
Cr-Original-Commit-Position: refs/heads/master@{#472952}
Review-Url: https://codereview.chromium.org/2896883002 .
Cr-Commit-Position: refs/branch-heads/3071@{#654}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/ef63c09a56bf127df9990b3e7412f543b4733b0b
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||