Fix ContentVerifierTest.FailOnDone and ContentVerifierTest.FailOnRead on Windows 10.

Fix ContentVerifierTest.FailOnDone and ContentVerifierTest.FailOnRead on Windows 10 with PlzNavigate.

The tests were loading a tab that would be closed. The test code was waiting for both a didstop IPC (inside InProcessBrowserTest::AddTabAtIndexToBrowser) and for the extension-unloaded notification (what the test is really testing). With PlzNavigate, the didstop IPC is sent later and it's racy whether the renderer will send it before the tab is closed. So remove the first wait.

BUG=699437
Review-Url: https://codereview.chromium.org/2896853005
Cr-Commit-Position: refs/heads/master@{#473949}
Committed: https://chromium.googlesource.com/chromium/src/+/c958dad1cb42b5e9ad6660b4fd35761b51444d5b

[jam, 2017-05-23 15:16:33]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[jam, 2017-05-23 15:16:37]

The CQ bit was unchecked by jam@chromium.org

[jam, 2017-05-23 15:17:01]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 15:17:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-05-23 15:20:35]

Description was changed from

==========
enable CV tests

BUG=
==========

to

==========
Fix ContentVerifierTest.FailOnDone and ContentVerifierTest.FailOnRead on Windows
10 with PlzNavigate.

The tests were loading a tab that would be closed. The test code was waiting for
both a didstop IPC (inside InProcessBrowserTest::AddTabAtIndexToBrowser) and for
the extension-unloaded notification (what the test is really testing). With
PlzNavigate, the didstop IPC is sent later and it's racy whether the renderer
will send it before the tab is closed. So remove the first wait.

BUG=699437
==========

[jam, 2017-05-23 15:20:35]

jam@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2017-05-23 16:06:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 16:06:07]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-05-23 16:13:05]

lgtm

https://codereview.chromium.org/2896853005/diff/60001/chrome/browser/extensio...
File chrome/browser/extensions/content_verifier_browsertest.cc (right):

https://codereview.chromium.org/2896853005/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/content_verifier_browsertest.cc:493: browser(),
page_url_, 0, WindowOpenDisposition::NEW_FOREGROUND_TAB,
Can you add a comment explaining why the '0' here is important?

[jam, 2017-05-23 16:18:33]

https://codereview.chromium.org/2896853005/diff/60001/chrome/browser/extensio...
File chrome/browser/extensions/content_verifier_browsertest.cc (right):

https://codereview.chromium.org/2896853005/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/content_verifier_browsertest.cc:493: browser(),
page_url_, 0, WindowOpenDisposition::NEW_FOREGROUND_TAB,
On 2017/05/23 16:13:05, Devlin (catching up) wrote:
> Can you add a comment explaining why the '0' here is important?

Done.

[jam, 2017-05-23 16:19:09]

The CQ bit was checked by jam@chromium.org

[jam, 2017-05-23 16:19:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2896853005/#ps80001
(title: "add comment")

[commit-bot: I haz the power, 2017-05-23 16:19:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 17:05:48]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495556349364500,
"parent_rev": "21b332056cc4435a440329e7975d65288143e283", "commit_rev":
"c958dad1cb42b5e9ad6660b4fd35761b51444d5b"}

[commit-bot: I haz the power, 2017-05-23 17:05:59]

Description was changed from

==========
Fix ContentVerifierTest.FailOnDone and ContentVerifierTest.FailOnRead on Windows
10 with PlzNavigate.

The tests were loading a tab that would be closed. The test code was waiting for
both a didstop IPC (inside InProcessBrowserTest::AddTabAtIndexToBrowser) and for
the extension-unloaded notification (what the test is really testing). With
PlzNavigate, the didstop IPC is sent later and it's racy whether the renderer
will send it before the tab is closed. So remove the first wait.

BUG=699437
==========

to

==========
Fix ContentVerifierTest.FailOnDone and ContentVerifierTest.FailOnRead on Windows
10 with PlzNavigate.

The tests were loading a tab that would be closed. The test code was waiting for
both a didstop IPC (inside InProcessBrowserTest::AddTabAtIndexToBrowser) and for
the extension-unloaded notification (what the test is really testing). With
PlzNavigate, the didstop IPC is sent later and it's racy whether the renderer
will send it before the tab is closed. So remove the first wait.

BUG=699437

Review-Url: https://codereview.chromium.org/2896853005
Cr-Commit-Position: refs/heads/master@{#473949}
Committed:
https://chromium.googlesource.com/chromium/src/+/c958dad1cb42b5e9ad6660b4fd35...
==========

[commit-bot: I haz the power, 2017-05-23 17:06:03]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/c958dad1cb42b5e9ad6660b4fd35...