Network traffic annotation added to Service Worker unittests.

Network traffic annotation added to Service Worker unittests.

Network traffic annotation is added to network requests of:
content/browser/service_worker/service_worker_request_handler_unittest.cc
content/browser/service_worker/service_worker_url_request_job_unittest.cc

BUG=656607
Review-Url: https://codereview.chromium.org/2896793002
Cr-Commit-Position: refs/heads/master@{#473808}
Committed: https://chromium.googlesource.com/chromium/src/+/bafb106ad2c293fac86c9865952e78d5b17ac921

[Ramin Halavati, 2017-05-22 07:40:44]

The CQ bit was checked by rhalavati@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 07:40:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 08:52:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 08:52:06]

Dry run: This issue passed the CQ dry run.

[Ramin Halavati, 2017-05-22 08:53:30]

rhalavati@chromium.org changed reviewers:
+ michaeln@chromium.org

[Ramin Halavati, 2017-05-22 08:53:30]

Michael,

I've added test network traffic annotation tags to service worker unittests,
please review.

[michaeln, 2017-05-23 00:26:33]

lgtm

[kinuko, 2017-05-23 03:11:26]

Would you be able to quickly teach me what 'traffic annotation' is for?  (The
description in the crbug seems also very short)

(lgtm)

[Ramin Halavati, 2017-05-23 04:25:30]

On 2017/05/23 03:11:26, kinuko wrote:
> Would you be able to quickly teach me what 'traffic annotation' is for?  (The
> description in the crbug seems also very short)
> 
> (lgtm)

I am sorry I did not add the intro to annotations as Michael was already
famililar with it. Here is the intro and please ask me if you needed any more
details:

We are annotating all network requests in Chromium with a new
NetworkTrafficAnnotation scheme. This allows enterprise users of Chrome to audit
the requests and configure Chrome in a way that meets their security policies
and expectations. Furthermore, it allows us to generate better debugging data in
chrome://net-internals and measure bandwidth consumption on a per-request-type
basis. If you want to learn more, see:
https://docs.google.com/document/d/1FWEFTHzdqIA1wHUo_DuSpJjppW22otCMPCOA5NumhJU.

Please take a look at the protobuf scheme in:
https://cs.chromium.org/chromium/src/tools/traffic_annotation/traffic_annotat...
for the definition of the annotations.

You can find a sample annotation in:
https://cs.chromium.org/chromium/src/components/spellcheck/browser/spelling_s...

Entriprise policy options are here:
https://cs.chromium.org/chromium/src/out/Debug/gen/components/policy/proto/ch...

And more description on enterprise policy settings is here:
http://dev.chromium.org/administrators/policy-list-3

[Ramin Halavati, 2017-05-23 04:25:37]

The CQ bit was checked by rhalavati@chromium.org

[commit-bot: I haz the power, 2017-05-23 04:25:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 04:30:29]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495513537752990, "parent_rev":
"d4019643c7a00fb27ab4b971040140d7826eb1ef", "commit_rev":
"bafb106ad2c293fac86c9865952e78d5b17ac921"}

[commit-bot: I haz the power, 2017-05-23 04:30:40]

Description was changed from

==========
Network traffic annotation added to Service Worker unittests.

Network traffic annotation is added to network requests of:
content/browser/service_worker/service_worker_request_handler_unittest.cc
content/browser/service_worker/service_worker_url_request_job_unittest.cc

BUG=656607
==========

to

==========
Network traffic annotation added to Service Worker unittests.

Network traffic annotation is added to network requests of:
content/browser/service_worker/service_worker_request_handler_unittest.cc
content/browser/service_worker/service_worker_url_request_job_unittest.cc

BUG=656607

Review-Url: https://codereview.chromium.org/2896793002
Cr-Commit-Position: refs/heads/master@{#473808}
Committed:
https://chromium.googlesource.com/chromium/src/+/bafb106ad2c293fac86c9865952e...
==========

[commit-bot: I haz the power, 2017-05-23 04:30:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bafb106ad2c293fac86c9865952e...

[kinuko, 2017-05-23 06:14:38]

On 2017/05/23 04:25:30, Ramin Halavati wrote:
> On 2017/05/23 03:11:26, kinuko wrote:
> > Would you be able to quickly teach me what 'traffic annotation' is for? 
(The
> > description in the crbug seems also very short)
> > 
> > (lgtm)
> 
> I am sorry I did not add the intro to annotations as Michael was already
> famililar with it. Here is the intro and please ask me if you needed any more
> details:
> 
> We are annotating all network requests in Chromium with a new
> NetworkTrafficAnnotation scheme. This allows enterprise users of Chrome to
audit
> the requests and configure Chrome in a way that meets their security policies
> and expectations. Furthermore, it allows us to generate better debugging data
in
> chrome://net-internals and measure bandwidth consumption on a per-request-type
> basis. If you want to learn more, see:
>
https://docs.google.com/document/d/1FWEFTHzdqIA1wHUo_DuSpJjppW22otCMPCOA5NumhJU.
> 
> Please take a look at the protobuf scheme in:
>
https://cs.chromium.org/chromium/src/tools/traffic_annotation/traffic_annotat...
> for the definition of the annotations.
> 
> You can find a sample annotation in:
>
https://cs.chromium.org/chromium/src/components/spellcheck/browser/spelling_s...
> 
> Entriprise policy options are here:
>
https://cs.chromium.org/chromium/src/out/Debug/gen/components/policy/proto/ch...
> 
> And more description on enterprise policy settings is here:
> http://dev.chromium.org/administrators/policy-list-3

Thanks! (And I found a little more info on the other SW patch)