Remove the kHideFullscreenToolbar Preference

Remove the kHideFullscreenToolbar Preference

The preference is deprecated and has been replaced by
kShowFullscreenToolbar.

BUG=590827
Review-Url: https://codereview.chromium.org/2896763003
Cr-Commit-Position: refs/heads/master@{#473736}
Committed: https://chromium.googlesource.com/chromium/src/+/ecea8e961951df9eacaa939ee512bc67ab43a48f

[spqchan, 2017-05-22 18:39:36]

Description was changed from

==========
Remove kHideFullscreenToolbar Preference

BUG=590827
==========

to

==========
Remove the kHideFullscreenToolbar Preference

BUG=590827
==========

[spqchan, 2017-05-22 18:39:37]

spqchan@chromium.org changed reviewers:
+ thestig@chromium.org

[spqchan, 2017-05-22 18:39:41]

The CQ bit was checked by spqchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 18:40:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[spqchan, 2017-05-22 19:58:55]

Description was changed from

==========
Remove the kHideFullscreenToolbar Preference

BUG=590827
==========

to

==========
Remove the kHideFullscreenToolbar Preference

The preference is deprecated and has been replaced by
kShowFullscreenToolbar

BUG=590827
==========

[spqchan, 2017-05-22 19:59:02]

Description was changed from

==========
Remove the kHideFullscreenToolbar Preference

The preference is deprecated and has been replaced by
kShowFullscreenToolbar

BUG=590827
==========

to

==========
Remove the kHideFullscreenToolbar Preference

The preference is deprecated and has been replaced by
kShowFullscreenToolbar.

BUG=590827
==========

[spqchan, 2017-05-22 19:59:15]

PTAL

[commit-bot: I haz the power, 2017-05-22 20:03:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 20:03:03]

Dry run: This issue passed the CQ dry run.

[spqchan, 2017-05-22 20:08:25]

PTAL

[Lei Zhang, 2017-05-22 22:48:12]

My experience with other profile preference migrations is that even though it
has been many milestones, there are probably still a non-trivial number of
migrations happening every day. Given the size of the user base, even a tiny
fraction is sometimes thousands of users.

So the question is, what happens if a user profile jumps from M45 to M60, and
skips this migration code?

[Lei Zhang, 2017-05-22 22:49:09]

This CL looks fine. We just need to figure out the impact from skipping the
migration code.

[spqchan, 2017-05-22 22:58:41]

On 2017/05/22 22:49:09, Lei Zhang wrote:
> This CL looks fine. We just need to figure out the impact from skipping the
> migration code.

If the user profile jumps before the migration, then they will lose their
"Always Show Toolbar in Full Screen" setting, and it will set to true by
default.
They can easily change the setting back by disabling it on the menu.

[Lei Zhang, 2017-05-22 23:01:30]

On 2017/05/22 22:58:41, spqchan wrote:
> On 2017/05/22 22:49:09, Lei Zhang wrote:
> > This CL looks fine. We just need to figure out the impact from skipping the
> > migration code.
> 
> If the user profile jumps before the migration, then they will lose their
> "Always Show Toolbar in Full Screen" setting, and it will set to true by
> default.
> They can easily change the setting back by disabling it on the menu.

lgtm

Sounds like it might be a little annoying, but not too terrible. Since this is
Mac-only, I expect even fewer users will hit this problem.

[spqchan, 2017-05-22 23:06:53]

On 2017/05/22 23:01:30, Lei Zhang wrote:
> On 2017/05/22 22:58:41, spqchan wrote:
> > On 2017/05/22 22:49:09, Lei Zhang wrote:
> > > This CL looks fine. We just need to figure out the impact from skipping
the
> > > migration code.
> > 
> > If the user profile jumps before the migration, then they will lose their
> > "Always Show Toolbar in Full Screen" setting, and it will set to true by
> > default.
> > They can easily change the setting back by disabling it on the menu.
> 
> lgtm
> 
> Sounds like it might be a little annoying, but not too terrible. Since this is
> Mac-only, I expect even fewer users will hit this problem.

thanks!

[spqchan, 2017-05-22 23:06:58]

The CQ bit was checked by spqchan@chromium.org

[commit-bot: I haz the power, 2017-05-22 23:07:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 23:13:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495494418630150, "parent_rev":
"965f939c0b2db8ecb2b7afd607f2b161d8872c06", "commit_rev":
"ecea8e961951df9eacaa939ee512bc67ab43a48f"}

[commit-bot: I haz the power, 2017-05-22 23:13:48]

Description was changed from

==========
Remove the kHideFullscreenToolbar Preference

The preference is deprecated and has been replaced by
kShowFullscreenToolbar.

BUG=590827
==========

to

==========
Remove the kHideFullscreenToolbar Preference

The preference is deprecated and has been replaced by
kShowFullscreenToolbar.

BUG=590827

Review-Url: https://codereview.chromium.org/2896763003
Cr-Commit-Position: refs/heads/master@{#473736}
Committed:
https://chromium.googlesource.com/chromium/src/+/ecea8e961951df9eacaa939ee512...
==========

[commit-bot: I haz the power, 2017-05-22 23:13:52]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ecea8e961951df9eacaa939ee512...