Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2896743003: Disable NGInlineLayoutAlgorithmTest.VerticalAlignBottomReplaced under ASan (Closed)

Created:
3 years, 7 months ago by hans
Modified:
3 years, 7 months ago
Reviewers:
Nico, kojii
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable NGInlineLayoutAlgorithmTest.VerticalAlignBottomReplaced under ASan It leaks memory. Disabling until the code is fixed. BUG=721932 R=kojii@chromium.org, thakis@chromium.org TBR=kojii CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Review-Url: https://codereview.chromium.org/2896743003 . Cr-Commit-Position: refs/heads/master@{#473639} Committed: https://chromium.googlesource.com/chromium/src/+/cabeb0d9ab1b39fc25a1647d38afade5bea2e70e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
hans
What do you think?
3 years, 7 months ago (2017-05-22 16:16:24 UTC) #4
Nico
As said on the bug, can we revert instead? On May 22, 2017 12:16 PM, ...
3 years, 7 months ago (2017-05-22 16:22:08 UTC) #5
Nico
As said on the bug, can we revert instead? On May 22, 2017 12:16 PM, ...
3 years, 7 months ago (2017-05-22 16:22:08 UTC) #6
Nico
Lgtm per bug.
3 years, 7 months ago (2017-05-22 16:44:00 UTC) #7
kojii
lgtm, thank you and sorry for the slow action.
3 years, 7 months ago (2017-05-22 16:46:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896743003/1
3 years, 7 months ago (2017-05-22 16:48:12 UTC) #10
hans
3 years, 7 months ago (2017-05-22 18:48:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cabeb0d9ab1b39fc25a1647d38afade5bea2e70e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698