Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 2896733002: [EasyUnlock] Reduce Bluetooth throttler time from 7 seconds to 2 seconds. (Closed)

Created:
3 years, 7 months ago by Tim Song
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, lesliewatkins+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[EasyUnlock] Reduce Bluetooth throttler time from 7 seconds to 1 seconds. Ideally, we should simply remove this throttling logic altogether, as it was used to work around some Bluetooth classic bugs. These bugs should no longer be relevant for BLE. However, to be safe, we'll simply reduce the throttling time first and see if this causes insability. BUG=724719 Review-Url: https://codereview.chromium.org/2896733002 Cr-Commit-Position: refs/heads/master@{#473648} Committed: https://chromium.googlesource.com/chromium/src/+/e9d3b3997673274a86176c159bf453012b747196

Patch Set 1 #

Total comments: 2

Patch Set 2 : [EasyUnlock] Reduce Bluetooth throttler time from 7 seconds to 2 seconds. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/cryptauth/bluetooth_throttler_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Tim Song
3 years, 7 months ago (2017-05-21 23:17:16 UTC) #2
sacomoto
lgtm https://codereview.chromium.org/2896733002/diff/1/components/cryptauth/bluetooth_throttler_impl.cc File components/cryptauth/bluetooth_throttler_impl.cc (right): https://codereview.chromium.org/2896733002/diff/1/components/cryptauth/bluetooth_throttler_impl.cc#newcode19 components/cryptauth/bluetooth_throttler_impl.cc:19: const int kCooldownTimeSecs = 2; nit: set it ...
3 years, 7 months ago (2017-05-22 07:44:46 UTC) #3
Tim Song
https://codereview.chromium.org/2896733002/diff/1/components/cryptauth/bluetooth_throttler_impl.cc File components/cryptauth/bluetooth_throttler_impl.cc (right): https://codereview.chromium.org/2896733002/diff/1/components/cryptauth/bluetooth_throttler_impl.cc#newcode19 components/cryptauth/bluetooth_throttler_impl.cc:19: const int kCooldownTimeSecs = 2; On 2017/05/22 07:44:46, sacomoto ...
3 years, 7 months ago (2017-05-22 18:10:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896733002/20001
3 years, 7 months ago (2017-05-22 18:11:34 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/e9d3b3997673274a86176c159bf453012b747196
3 years, 7 months ago (2017-05-22 19:11:39 UTC) #11
Ryan Hansberry
3 years, 7 months ago (2017-05-22 19:50:39 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698