Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2896723003: Generate enum/getters/setters/mappings for speak. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate enum/getters/setters/mappings for speak. Currently, the speak property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to a 'keyword' field so that its getters/setters can be generated as well. We also generate the ESpeak enum and use the generated CSSValueID <-> ESpeak mappings. Diff of generated files: https://gist.github.com/aba737ebdcd44f1ee7c05cf332c64324/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2896723003 Cr-Commit-Position: refs/heads/master@{#474936} Committed: https://chromium.googlesource.com/chromium/src/+/c1148176d6794fff0fd8dba2b9f7ed71ec52fed8

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -61 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 2 2 chunks +0 lines, -48 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 2 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 28 (22 generated)
shend
Hi Eddy, PTAL
3 years, 7 months ago (2017-05-24 00:15:02 UTC) #4
rune
lgtm
3 years, 7 months ago (2017-05-24 06:19:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896723003/20001
3 years, 7 months ago (2017-05-25 03:58:28 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/447117)
3 years, 7 months ago (2017-05-25 04:08:31 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896723003/40001
3 years, 7 months ago (2017-05-26 06:02:06 UTC) #25
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 06:07:10 UTC) #28
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c1148176d6794fff0fd8dba2b9f7...

Powered by Google App Engine
This is Rietveld 408576698