Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 2896703005: [NaCl SDK] Fix location of gmock and gtest libraries (Closed)

Created:
3 years, 7 months ago by Sam Clegg
Modified:
3 years, 7 months ago
Reviewers:
binji
CC:
binji+watch_chromium.org, chromium-reviews, Sam Clegg
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Fix location of gmock and gtest libraries This fixes the SDK build which was broken when these libraries were moved. BUG=724707 Review-Url: https://codereview.chromium.org/2896703005 Cr-Commit-Position: refs/heads/master@{#473730} Committed: https://chromium.googlesource.com/chromium/src/+/1ba1aa2f95523e8402a9480b876491f802a97b48

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M native_client_sdk/src/libraries/gmock/library.dsc View 1 chunk +1 line, -3 lines 0 comments Download
M native_client_sdk/src/libraries/gtest/library.dsc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Sam Clegg
3 years, 7 months ago (2017-05-22 19:32:05 UTC) #2
binji
lgtm
3 years, 7 months ago (2017-05-22 22:46:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896703005/1
3 years, 7 months ago (2017-05-22 22:49:53 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 22:59:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1ba1aa2f95523e8402a9480b8764...

Powered by Google App Engine
This is Rietveld 408576698