Package the translation_unit tool as part of building the clang package.

Package the translation_unit tool as part of building the clang package.

It will go in a separate tarball and be consumed by the codesearch buildbot.

Getting built by default in update.py also means our ToT bots will catch any
breakages due to upstream changes in clang.

BUG=724686
Review-Url: https://codereview.chromium.org/2896663002
Cr-Commit-Position: refs/heads/master@{#474576}
Committed: https://chromium.googlesource.com/chromium/src/+/2aa36cd3f1ae44ee75d549304bdf568798528917

[emso, 2017-05-22 15:24:06]

Description was changed from

==========
Package the translation_unit tool as part of building the clang package.

It will go in a separate tarball and be consumed by the codesearch buildbot.

Getting built by default in update.py also means our ToT bots will catch any
breakages due to upstream changes in clang.

BUG=724686
==========

to

==========
Package the translation_unit tool as part of building the clang package.

It will go in a separate tarball and be consumed by the codesearch buildbot.

Getting built by default in update.py also means our ToT bots will catch any
breakages due to upstream changes in clang.

BUG=724686
==========

[emso, 2017-05-22 15:28:47]

emso@chromium.org changed reviewers:
+ emso@chromium.org

[emso, 2017-05-22 15:28:47]

This seems to be aimed at Linux. Any chance we can set this up for other
configurations as well? We want to add, for instance, Windows.

[hans, 2017-05-22 22:35:57]

hans@chromium.org changed reviewers:
+ thakis@chromium.org

[hans, 2017-05-22 22:35:58]

Updated the patch to make it build on all platforms. I've verified that
packaging works on Windows, but I haven't tried the actual tool.

I also haven't tried the download script, but that can be iterated on quickly if
there are problems.

Nico, what do you think?

[Nico, 2017-05-24 23:06:28]

On 2017/05/22 22:35:58, hans wrote:
> Updated the patch to make it build on all platforms. I've verified that
> packaging works on Windows, but I haven't tried the actual tool.
> 
> I also haven't tried the download script, but that can be iterated on quickly
if
> there are problems.
> 
> Nico, what do you think?

Abstractly I think update.py already does many things, and I'm not sure it
should do more. But the patch is small. So I'd say let's land this and see how
it goes, and if it turns out to become more involved, we can put this elsewhere
later. So lgtm.

[hans, 2017-05-24 23:08:01]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2017-05-24 23:08:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 03:02:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 03:02:19]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[hans, 2017-05-25 04:44:31]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2017-05-25 04:44:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 05:58:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495687471078700,
"parent_rev": "007b4ee003ffd1cb390aecb6b07579797eb35382", "commit_rev":
"2aa36cd3f1ae44ee75d549304bdf568798528917"}

[commit-bot: I haz the power, 2017-05-25 05:58:12]

Description was changed from

==========
Package the translation_unit tool as part of building the clang package.

It will go in a separate tarball and be consumed by the codesearch buildbot.

Getting built by default in update.py also means our ToT bots will catch any
breakages due to upstream changes in clang.

BUG=724686
==========

to

==========
Package the translation_unit tool as part of building the clang package.

It will go in a separate tarball and be consumed by the codesearch buildbot.

Getting built by default in update.py also means our ToT bots will catch any
breakages due to upstream changes in clang.

BUG=724686

Review-Url: https://codereview.chromium.org/2896663002
Cr-Commit-Position: refs/heads/master@{#474576}
Committed:
https://chromium.googlesource.com/chromium/src/+/2aa36cd3f1ae44ee75d549304bdf...
==========

[commit-bot: I haz the power, 2017-05-25 05:58:18]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2aa36cd3f1ae44ee75d549304bdf...