Issue 2896653003: Make KeyboardEvent have direct fields for keyCode/charCode, as they're no longer inherited from UIE…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2896653003: Make KeyboardEvent have direct fields for keyCode/charCode, as they're no longer inherited from UIE… (Closed)

Created:
3 years, 7 months ago by Alan Knight

Modified:
3 years, 7 months ago

Reviewers:
terry

CC:
reviews_dartlang.org, vsm

Target Ref:
refs/heads/master

Visibility:
Public.

Make KeyboardEvent have direct fields for keyCode/charCode, as they're no longer inherited from UIEvent BUG= R=terry@google.com Committed: https://github.com/dart-lang/sdk/commit/9e0297f49e9fce3eb746e430acdf6a27ab0740bb

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -5 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/html/html.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/dom/templates/html/dart2js/impl_KeyboardEvent.darttemplate	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Alan Knight

3 years, 7 months ago (2017-05-22 17:29:31 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9e0297f49e9fce3eb746e430acdf6a27ab0740bb (presubmit successful).