sdk/lib/html/dart2js/html_dart2js.dart - Issue 2896653003: Make KeyboardEvent have direct fields for keyCode/charCode, as they're no longer inherited from UIE…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Side-by-side diff isn't available for this file because of its large size.

Issue 2896653003: Make KeyboardEvent have direct fields for keyCode/charCode, as they're no longer inherited from UIE… (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/html/dart2js/html_dart2js.dart

diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart

index 76e3a5a1f8952c7eab4951237be7962074899db7..c8ca2a9d4fb8bfbf34d72433985ee4e81a147b91 100644

--- a/sdk/lib/html/dart2js/html_dart2js.dart

+++ b/sdk/lib/html/dart2js/html_dart2js.dart

@@ -22176,10 +22176,10 @@ class KeyboardEvent extends UIEvent {

}

@DomName('KeyboardEvent.keyCode')

- int get keyCode => _keyCode;

+ final int keyCode;

@DomName('KeyboardEvent.charCode')

- int get charCode => _charCode;

+ final int charCode;

@DomName('KeyboardEvent.which')

int get which => _which;

« no previous file with comments | « no previous file | tests/html/html.status » ('j') | no next file with comments »