Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2896643002: Upstream service wrkr "iframe sandbox" test to WPT (Closed)

Created:
3 years, 7 months ago by mike3
Modified:
3 years, 7 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, blink-reviews-w3ctests_chromium.org, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream service wrkr "iframe sandbox" test to WPT **sandbox-iframe-register-link-element** Re-locate test files to Web Platform Test directory for eventual automated upstreaming. Re-factor to use `promise_test`. Add additional subtest verifying observance of the `allow-same-origin` directive. Remove unnecessary `<script>` tag. Add "use strict" directives to scripts. BUG=688116 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2896643002 Cr-Commit-Position: refs/heads/master@{#473585} Committed: https://chromium.googlesource.com/chromium/src/+/06e4fc07e59c52bfcdb94b424b6ffef20245ada3

Patch Set 1 #

Messages

Total messages: 8 (4 generated)
mike3
Hi Matt, I'm afraid the diff for this one isn't particularly helpful since the refactoring ...
3 years, 7 months ago (2017-05-19 22:17:04 UTC) #2
falken
lgtm, nice cleanup
3 years, 7 months ago (2017-05-22 04:33:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896643002/1
3 years, 7 months ago (2017-05-22 14:45:50 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 16:05:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/06e4fc07e59c52bfcdb94b424b6f...

Powered by Google App Engine
This is Rietveld 408576698