Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: ios/web/public/test/fakes/crw_test_web_state_observer.mm

Issue 2896623003: Added web::NavigationContext::GetPageTransition. (Closed)
Patch Set: Fixed condition for SetIsCreatedFromHashChange call Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/public/test/fakes/crw_test_web_state_observer.mm
diff --git a/ios/web/public/test/fakes/crw_test_web_state_observer.mm b/ios/web/public/test/fakes/crw_test_web_state_observer.mm
index 36eb86f36d2490257f3d11949463b7fe0a47d412..5727463ab9793661fee43fe15a9d9ce108334709 100644
--- a/ios/web/public/test/fakes/crw_test_web_state_observer.mm
+++ b/ios/web/public/test/fakes/crw_test_web_state_observer.mm
@@ -132,7 +132,8 @@ TestUpdateFaviconUrlCandidatesInfo::~TestUpdateFaviconUrlCandidatesInfo() =
_didStartNavigationInfo->web_state = webState;
std::unique_ptr<web::NavigationContextImpl> context =
web::NavigationContextImpl::CreateNavigationContext(
- navigation->GetWebState(), navigation->GetUrl());
+ navigation->GetWebState(), navigation->GetUrl(),
+ navigation->GetPageTransition());
context->SetIsSameDocument(navigation->IsSameDocument());
context->SetIsErrorPage(navigation->IsErrorPage());
_didStartNavigationInfo->context = std::move(context);
@@ -154,7 +155,8 @@ TestUpdateFaviconUrlCandidatesInfo::~TestUpdateFaviconUrlCandidatesInfo() =
_didFinishNavigationInfo->web_state = webState;
std::unique_ptr<web::NavigationContextImpl> context =
web::NavigationContextImpl::CreateNavigationContext(
- navigation->GetWebState(), navigation->GetUrl());
+ navigation->GetWebState(), navigation->GetUrl(),
+ navigation->GetPageTransition());
context->SetIsSameDocument(navigation->IsSameDocument());
context->SetIsErrorPage(navigation->IsErrorPage());
_didFinishNavigationInfo->context = std::move(context);

Powered by Google App Engine
This is Rietveld 408576698