Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: ios/chrome/browser/tabs/tab_unittest.mm

Issue 2896623003: Added web::NavigationContext::GetPageTransition. (Closed)
Patch Set: Fixed condition for SetIsCreatedFromHashChange call Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/tabs/tab_unittest.mm
diff --git a/ios/chrome/browser/tabs/tab_unittest.mm b/ios/chrome/browser/tabs/tab_unittest.mm
index d9ad849212682060903741ba4615d98375ed6bc2..41c22b906385d6040acc0ea7c486fcbce05d94c8 100644
--- a/ios/chrome/browser/tabs/tab_unittest.mm
+++ b/ios/chrome/browser/tabs/tab_unittest.mm
@@ -234,7 +234,8 @@ class TabTest : public BlockCleanupTest {
[tab_ webWillAddPendingURL:userUrl transition:ui::PAGE_TRANSITION_TYPED];
std::unique_ptr<web::NavigationContext> context1 =
web::NavigationContextImpl::CreateNavigationContext(
- web_state_impl_.get(), userUrl);
+ web_state_impl_.get(), userUrl,
+ ui::PageTransition::PAGE_TRANSITION_TYPED);
web_state_impl_->OnNavigationStarted(context1.get());
[tab_ webWillAddPendingURL:redirectUrl
transition:ui::PAGE_TRANSITION_CLIENT_REDIRECT];
@@ -247,7 +248,8 @@ class TabTest : public BlockCleanupTest {
std::unique_ptr<web::NavigationContext> context2 =
web::NavigationContextImpl::CreateNavigationContext(
- web_state_impl_.get(), redirectUrl);
+ web_state_impl_.get(), redirectUrl,
+ ui::PageTransition::PAGE_TRANSITION_TYPED);
web_state_impl_->OnNavigationStarted(context2.get());
[[tab_ navigationManagerImpl]->GetSessionController() commitPendingItem];
web_state_impl_->UpdateHttpResponseHeaders(redirectUrl);
« no previous file with comments | « no previous file | ios/web/public/test/fakes/crw_test_web_state_observer.mm » ('j') | ios/web/web_state/ui/crw_web_controller.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698