Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2896623002: [Payment Request] Country selection coordinator (Closed)

Created:
3 years, 7 months ago by Moe
Modified:
3 years, 7 months ago
Reviewers:
macourteau
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payment Request] Country selection coordinator BUG=602666 Review-Url: https://codereview.chromium.org/2896623002 Cr-Commit-Position: refs/heads/master@{#473442} Committed: https://chromium.googlesource.com/chromium/src/+/33e4db7af75ccf6cbe33a19e5c599b4e8876e02c

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -0 lines) Patch
M ios/chrome/browser/ui/payments/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/payments/country_selection_coordinator.h View 1 chunk +43 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/payments/country_selection_coordinator.mm View 1 1 chunk +94 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/payments/country_selection_coordinator_unittest.mm View 1 chunk +38 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_picker_view_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Moe
Hi MAC, Please take a look.
3 years, 7 months ago (2017-05-19 18:57:20 UTC) #2
macourteau
lgtm w/ nit https://codereview.chromium.org/2896623002/diff/1/ios/chrome/browser/ui/payments/country_selection_coordinator.mm File ios/chrome/browser/ui/payments/country_selection_coordinator.mm (right): https://codereview.chromium.org/2896623002/diff/1/ios/chrome/browser/ui/payments/country_selection_coordinator.mm#newcode18 ios/chrome/browser/ui/payments/country_selection_coordinator.mm:18: // The delay in nano seconds ...
3 years, 7 months ago (2017-05-19 20:20:43 UTC) #3
Moe
Thanks. https://codereview.chromium.org/2896623002/diff/1/ios/chrome/browser/ui/payments/country_selection_coordinator.mm File ios/chrome/browser/ui/payments/country_selection_coordinator.mm (right): https://codereview.chromium.org/2896623002/diff/1/ios/chrome/browser/ui/payments/country_selection_coordinator.mm#newcode18 ios/chrome/browser/ui/payments/country_selection_coordinator.mm:18: // The delay in nano seconds before notifying ...
3 years, 7 months ago (2017-05-19 22:19:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896623002/20001
3 years, 7 months ago (2017-05-19 22:19:58 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/298674)
3 years, 7 months ago (2017-05-19 23:37:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896623002/20001
3 years, 7 months ago (2017-05-20 17:54:07 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-20 17:58:30 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/33e4db7af75ccf6cbe33a19e5c59...

Powered by Google App Engine
This is Rietveld 408576698