Implements CSSPropertyAPI for the animation-name property.

Implements CSSPropertyAPI for the animation-name property.

This patch:
- Adds CSSPropertyAPIAnimationName.cpp with parseSingleValue method.
- Moves parsing logic for animation-name from CSSPropertyParser.cpp to
  CSSPropertyAPIAnimationName::parseSingleValue method.
- Moves shared function ConsumeCommaSeparatedList to
  CSSPropertyAnimationNameUtils.h
- Modifies BUILD and json5 files.

Diff: https://gist.github.com/jm318/8998e767a695314c7e1ee3e0c809d2d0/revisions
Review-Url: https://codereview.chromium.org/2896543002
Cr-Commit-Position: refs/heads/master@{#475423}
Committed: https://chromium.googlesource.com/chromium/src/+/f6b5778991df9e3119199d848f815b3b3f920f5c

[Jia, 2017-05-19 05:44:57]

Description was changed from

==========
Implements CSSPropertyAPI for the animation-name property.

This patch:
- Adds CSSPropertyAPIAnimationName.cpp with parseSingleValue method.
- Moves parsing logic for animation-name from CSSPropertyParser.cpp to
  CSSPropertyAPIAnimationName::parseSingleValue method.
- Moves shared function ConsumeCommaSeparatedList to
  CSSPropertyAnimationNameUtils.h
- Modifies BUILD and json5 files.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the animation-name property.

This patch:
- Adds CSSPropertyAPIAnimationName.cpp with parseSingleValue method.
- Moves parsing logic for animation-name from CSSPropertyParser.cpp to
  CSSPropertyAPIAnimationName::parseSingleValue method.
- Moves shared function ConsumeCommaSeparatedList to
  CSSPropertyAnimationNameUtils.h
- Modifies BUILD and json5 files.

Diff:https://gist.github.com/jm318/8998e767a695314c7e1ee3e0c809d2d0
BUG=668012
==========

[Jia, 2017-05-19 05:45:09]

Description was changed from

==========
Implements CSSPropertyAPI for the animation-name property.

This patch:
- Adds CSSPropertyAPIAnimationName.cpp with parseSingleValue method.
- Moves parsing logic for animation-name from CSSPropertyParser.cpp to
  CSSPropertyAPIAnimationName::parseSingleValue method.
- Moves shared function ConsumeCommaSeparatedList to
  CSSPropertyAnimationNameUtils.h
- Modifies BUILD and json5 files.

Diff:https://gist.github.com/jm318/8998e767a695314c7e1ee3e0c809d2d0
BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the animation-name property.

This patch:
- Adds CSSPropertyAPIAnimationName.cpp with parseSingleValue method.
- Moves parsing logic for animation-name from CSSPropertyParser.cpp to
  CSSPropertyAPIAnimationName::parseSingleValue method.
- Moves shared function ConsumeCommaSeparatedList to
  CSSPropertyAnimationNameUtils.h
- Modifies BUILD and json5 files.

Diff: https://gist.github.com/jm318/8998e767a695314c7e1ee3e0c809d2d0
BUG=668012
==========

[Jia, 2017-05-19 06:05:11]

Description was changed from

==========
Implements CSSPropertyAPI for the animation-name property.

This patch:
- Adds CSSPropertyAPIAnimationName.cpp with parseSingleValue method.
- Moves parsing logic for animation-name from CSSPropertyParser.cpp to
  CSSPropertyAPIAnimationName::parseSingleValue method.
- Moves shared function ConsumeCommaSeparatedList to
  CSSPropertyAnimationNameUtils.h
- Modifies BUILD and json5 files.

Diff: https://gist.github.com/jm318/8998e767a695314c7e1ee3e0c809d2d0
BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the animation-name property.

This patch:
- Adds CSSPropertyAPIAnimationName.cpp with parseSingleValue method.
- Moves parsing logic for animation-name from CSSPropertyParser.cpp to
  CSSPropertyAPIAnimationName::parseSingleValue method.
- Moves shared function ConsumeCommaSeparatedList to
  CSSPropertyAnimationNameUtils.h
- Modifies BUILD and json5 files.

Diff: https://gist.github.com/jm318/8998e767a695314c7e1ee3e0c809d2d0/revisions
BUG=668012
==========

[Jia, 2017-05-19 06:05:45]

jiameng@chromium.org changed reviewers:
+ bugsnash@chromium.org

[alancutter (OOO until 2018), 2017-05-19 06:11:17]

alancutter@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2017-05-19 06:11:17]

lgtm

[Bugs Nash, 2017-05-19 06:18:48]

lgtm for this patch, however I think that the CSSPropertyID argument should be
changed to a bool before implementing any more of the aliased properties

https://codereview.chromium.org/2896543002/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationNameUtils.h
(right):

https://codereview.chromium.org/2896543002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationNameUtils.h:21:
bool);
I think the name of the bool should be included here for readability

[Jia, 2017-05-30 01:03:48]

The CQ bit was checked by jiameng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 01:03:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jia, 2017-05-30 01:04:47]

On 2017/05/19 06:18:48, Bugs Nash wrote:
> lgtm for this patch, however I think that the CSSPropertyID argument should be
> changed to a bool before implementing any more of the aliased properties
> 
>
https://codereview.chromium.org/2896543002/diff/1/third_party/WebKit/Source/c...
> File
> third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationNameUtils.h
> (right):
> 
>
https://codereview.chromium.org/2896543002/diff/1/third_party/WebKit/Source/c...
>
third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationNameUtils.h:21:
> bool);
> I think the name of the bool should be included here for readability

I've changed parseSingleValue to take local context as input (instead of
use_alias_parsing).

[Jia, 2017-05-30 01:05:01]

https://codereview.chromium.org/2896543002/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationNameUtils.h
(right):

https://codereview.chromium.org/2896543002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyAnimationNameUtils.h:21:
bool);
On 2017/05/19 06:18:47, Bugs Nash wrote:
> I think the name of the bool should be included here for readability

Done.

[commit-bot: I haz the power, 2017-05-30 04:16:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 04:17:00]

Dry run: This issue passed the CQ dry run.

[Jia, 2017-05-30 04:20:26]

The CQ bit was checked by jiameng@chromium.org

[Jia, 2017-05-30 04:20:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
bugsnash@chromium.org, alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2896543002/#ps20001
(title: "Change parseSingleValue method to take local context as input.")

[commit-bot: I haz the power, 2017-05-30 04:20:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 04:24:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496118026165550,
"parent_rev": "ee625a76bb992853cd9a73625f25deeecfeb0d83", "commit_rev":
"f6b5778991df9e3119199d848f815b3b3f920f5c"}

[commit-bot: I haz the power, 2017-05-30 04:24:16]

Description was changed from

==========
Implements CSSPropertyAPI for the animation-name property.

This patch:
- Adds CSSPropertyAPIAnimationName.cpp with parseSingleValue method.
- Moves parsing logic for animation-name from CSSPropertyParser.cpp to
  CSSPropertyAPIAnimationName::parseSingleValue method.
- Moves shared function ConsumeCommaSeparatedList to
  CSSPropertyAnimationNameUtils.h
- Modifies BUILD and json5 files.

Diff: https://gist.github.com/jm318/8998e767a695314c7e1ee3e0c809d2d0/revisions
BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the animation-name property.

This patch:
- Adds CSSPropertyAPIAnimationName.cpp with parseSingleValue method.
- Moves parsing logic for animation-name from CSSPropertyParser.cpp to
  CSSPropertyAPIAnimationName::parseSingleValue method.
- Moves shared function ConsumeCommaSeparatedList to
  CSSPropertyAnimationNameUtils.h
- Modifies BUILD and json5 files.

Diff: https://gist.github.com/jm318/8998e767a695314c7e1ee3e0c809d2d0/revisions
Review-Url: https://codereview.chromium.org/2896543002
Cr-Commit-Position: refs/heads/master@{#475423}
Committed:
https://chromium.googlesource.com/chromium/src/+/f6b5778991df9e3119199d848f81...
==========

[commit-bot: I haz the power, 2017-05-30 04:24:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f6b5778991df9e3119199d848f81...