Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 2896523004: Touch memory ablation payload in chunks. (Closed)

Created:
3 years, 7 months ago by DmitrySkiba
Modified:
3 years, 7 months ago
Reviewers:
brettw, Maria
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Touch memory ablation payload in chunks. It was discovered that touching (to dirty pages) large regions of memory can be very costly on Android (~60ms per 10MiB on Nexus 5). We touch on IO thread, but still, it's better not to block it for long periods. With this CL we'll touch the ablation payload in chunks and we'll schedule each touch individually to let other things to happen in between. BUG=710048 Review-Url: https://codereview.chromium.org/2896523004 Cr-Commit-Position: refs/heads/master@{#473459} Committed: https://chromium.googlesource.com/chromium/src/+/33b723f0e62efbc4986c3f8dba52699c00a6e8a4

Patch Set 1 #

Total comments: 1

Patch Set 2 : Clarify Unretained(this) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -8 lines) Patch
M chrome/browser/experiments/memory_ablation_experiment.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/experiments/memory_ablation_experiment.cc View 1 3 chunks +34 lines, -7 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
DmitrySkiba
3 years, 7 months ago (2017-05-19 17:30:06 UTC) #2
Maria
lgtm
3 years, 7 months ago (2017-05-19 18:00:53 UTC) #3
brettw
lgtm https://codereview.chromium.org/2896523004/diff/1/chrome/browser/experiments/memory_ablation_experiment.cc File chrome/browser/experiments/memory_ablation_experiment.cc (right): https://codereview.chromium.org/2896523004/diff/1/chrome/browser/experiments/memory_ablation_experiment.cc#newcode101 chrome/browser/experiments/memory_ablation_experiment.cc:101: task_runner_->PostDelayedTask( Can you comment here that this task ...
3 years, 7 months ago (2017-05-19 20:41:49 UTC) #4
DmitrySkiba
On 2017/05/19 20:41:49, brettw wrote: > lgtm > > https://codereview.chromium.org/2896523004/diff/1/chrome/browser/experiments/memory_ablation_experiment.cc > File chrome/browser/experiments/memory_ablation_experiment.cc (right): > ...
3 years, 7 months ago (2017-05-19 22:21:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896523004/20001
3 years, 7 months ago (2017-05-19 22:21:54 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/298752)
3 years, 7 months ago (2017-05-19 23:41:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896523004/20001
3 years, 7 months ago (2017-05-20 00:04:02 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/298869)
3 years, 7 months ago (2017-05-20 03:24:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896523004/20001
3 years, 7 months ago (2017-05-21 03:39:14 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-21 04:25:25 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/33b723f0e62efbc4986c3f8dba52...

Powered by Google App Engine
This is Rietveld 408576698