Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2896483003: [Home] Hide sheet when back pressed (Closed)

Created:
3 years, 7 months ago by mdjones
Modified:
3 years, 7 months ago
Reviewers:
Ted C, Theresa
CC:
chromium-reviews, jdonnelly+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Hide sheet when back pressed This change allows a single press of the back button to close the bottom sheet if expanded via omnibox focus. This allows a user to easily return to the page if they decide against using the omnibox. The mechanism for detecting this case is simple: if the placeholder content is showing, defocus and hide everything with one press. The reason this works is because the placeholder sheet content will only be showing if the user expanded the sheet from the peeking state by focusing the omnibox. BUG=716224 Review-Url: https://codereview.chromium.org/2896483003 Cr-Commit-Position: refs/heads/master@{#473212} Committed: https://chromium.googlesource.com/chromium/src/+/e309521b316083148b2b2073fb589a086e010bc7

Patch Set 1 #

Patch Set 2 : extra check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java View 1 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
mdjones
ptal
3 years, 7 months ago (2017-05-18 20:46:27 UTC) #2
Theresa
lgtm
3 years, 7 months ago (2017-05-18 20:48:40 UTC) #3
mdjones
+tedchoc ptal
3 years, 7 months ago (2017-05-18 20:49:16 UTC) #5
Ted C
lgtm
3 years, 7 months ago (2017-05-18 23:48:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896483003/20001
3 years, 7 months ago (2017-05-19 16:03:39 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 16:45:36 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e309521b316083148b2b2073fb58...

Powered by Google App Engine
This is Rietveld 408576698