Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 2896473002: Remove FILE thread dependency in protocol_handler_registry_unittest.cc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by Patrick Monette
Modified:
1 month ago
Reviewers:
benwells, Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FILE thread dependency in protocol_handler_registry_unittest.cc BUG=724293, 689520 Review-Url: https://codereview.chromium.org/2896473002 Cr-Commit-Position: refs/heads/master@{#473349} Committed: https://chromium.googlesource.com/chromium/src/+/fd04fe52772ad91203606d3797d5e7a8b6226c04

Patch Set 1 #

Patch Set 2 : Changing comment #

Patch Set 3 : MakeShared to MakeRefCounted #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -134 lines) Patch
M chrome/browser/custom_handlers/protocol_handler_registry.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry.cc View 1 2 3 chunks +6 lines, -17 lines 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 10 chunks +22 lines, -105 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc View 2 chunks +2 lines, -8 lines 0 comments Download
Commit queue not available (can’t edit this change).

Dependent Patchsets:

Messages

Total messages: 26 (17 generated)
Patrick Monette
benwells@ PTAL at protocol_handler_registry* pkasting@ PTAL at content_setting_bubble_model_unittest.cc
1 month ago (2017-05-18 23:45:00 UTC) #12
Patrick Monette
Actually adding Peter
1 month ago (2017-05-18 23:45:15 UTC) #14
Peter Kasting
LGTM
1 month ago (2017-05-19 02:05:06 UTC) #15
benwells
lgtm, thanks for cleaning this up
1 month ago (2017-05-19 02:59:49 UTC) #16
Patrick Monette
Thanks!
1 month ago (2017-05-19 17:43:48 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896473002/40001
1 month ago (2017-05-19 17:44:59 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/450068)
1 month ago (2017-05-19 20:03:49 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896473002/40001
1 month ago (2017-05-19 21:08:07 UTC) #23
commit-bot: I haz the power
1 month ago (2017-05-19 22:04:44 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fd04fe52772ad91203606d3797d5...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318