third_party/WebKit/Source/platform/weborigin/KURL.cpp - Issue 2896443003: Replace remaining ASSERT with DCHECK/_EQ as appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/weborigin/KURL.cpp

Issue 2896443003: Replace remaining ASSERT with DCHECK/_EQ as appropriate (Closed)

Patch Set: actually fix WorkerBackingthread Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/weborigin/KURL.cpp

diff --git a/third_party/WebKit/Source/platform/weborigin/KURL.cpp b/third_party/WebKit/Source/platform/weborigin/KURL.cpp

index 60d37cdfc51bc6f67146a900553813e1ca0da2db..7a007753db82b4305e150f6d9e50b9d633783f22 100644

--- a/third_party/WebKit/Source/platform/weborigin/KURL.cpp

+++ b/third_party/WebKit/Source/platform/weborigin/KURL.cpp

@@ -833,7 +833,7 @@ bool KURL::ProtocolIs(const StringView protocol) const {

// they are invalid. The free function protocolIsJavaScript() should be used

// instead.

// FIXME: Chromium code needs to be fixed for this assert to be enabled.

- // ASSERT(strcmp(protocol, "javascript"));

+ // DCHECK(strcmp(protocol, "javascript"));

return protocol_ == protocol;

}